Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 217283004: Migrate addMessageToConsole API to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: back to PS1 Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/web/WebFrameClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 89b4c6dd145c9ed007ba902ef9da712807af499b..c01d7ea53623a4bf08bb211942a17b74b5078202 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -365,11 +365,24 @@ void ChromeClientImpl::setResizable(bool value)
bool ChromeClientImpl::shouldReportDetailedMessageForSource(const String& url)
{
- return m_webView->client() && m_webView->client()->shouldReportDetailedMessageForSource(url);
+ WebFrameImpl* webframe = m_webView->mainFrameImpl();
+ // TODO(mkosiba): remove once Chrome side is updated.
+ bool shouldReport = m_webView->client() && m_webView->client()->shouldReportDetailedMessageForSource(url);
+ shouldReport &= webframe->client() && webframe->client()->shouldReportDetailedMessageForSource(url);
+ return shouldReport;
}
void ChromeClientImpl::addMessageToConsole(MessageSource source, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace)
{
+ WebFrameImpl* webframe = m_webView->mainFrameImpl();
+ if (webframe->client()) {
+ webframe->client()->didAddMessageToConsole(
+ WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
+ sourceID,
+ lineNumber,
+ stackTrace);
+ }
+ // TODO(mkosiba): remove once Chrome side is updated.
if (m_webView->client()) {
m_webView->client()->didAddMessageToConsole(
WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
« no previous file with comments | « no previous file | public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698