Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2172023002: chrome/browser/chromeos: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, hidehiko+watch_chromium.org, dzhioev+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, je_julie, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/chromeos: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=oshima@chromium.org BUG=554600 Committed: https://crrev.com/668a5386d4e352fccf29893b848797d2993fa8b2 Cr-Commit-Position: refs/heads/master@{#407605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_process_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/base/file_flusher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/upload_job_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/resource_reporter/resource_reporter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-22 00:27:23 UTC) #1
oshima
lgtm
4 years, 5 months ago (2016-07-22 19:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172023002/1
4 years, 5 months ago (2016-07-25 21:11:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:57:52 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:59:48 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/668a5386d4e352fccf29893b848797d2993fa8b2
Cr-Commit-Position: refs/heads/master@{#407605}

Powered by Google App Engine
This is Rietveld 408576698