chrome/browser/chromeos/base/file_flusher.cc - Issue 2172023002: chrome/browser/chromeos: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/base/file_flusher.cc

Issue 2172023002: chrome/browser/chromeos: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/base/file_flusher.cc

diff --git a/chrome/browser/chromeos/base/file_flusher.cc b/chrome/browser/chromeos/base/file_flusher.cc

index 4315dbf2d4f2f78267a53acd63ee9bdf8a1ccca9..43e06b5875dd34e5c58c3c566196ba7c1a353dab 100644

--- a/chrome/browser/chromeos/base/file_flusher.cc

+++ b/chrome/browser/chromeos/base/file_flusher.cc

@@ -166,14 +166,14 @@ void FileFlusher::Job::FinishOnUIThread() {

FileFlusher::FileFlusher() : weak_factory_(this) {}

FileFlusher::~FileFlusher() {

- for (const auto& job : jobs_)

+ for (auto* job : jobs_)

job->Cancel();

}

void FileFlusher::RequestFlush(const base::FilePath& path,

const std::vector<base::FilePath>& excludes,

const base::Closure& callback) {

- for (const auto& job : jobs_) {

+ for (auto* job : jobs_) {

if (path == job->path() || path.IsParent(job->path()))

job->Cancel();

}

@@ -187,7 +187,7 @@ void FileFlusher::ScheduleJob() {

if (jobs_.empty())

return;

- auto job = jobs_.front();

+ auto* job = jobs_.front();

if (!job->started())

job->Start();

}