Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: chrome/browser/chromeos/resource_reporter/resource_reporter.cc

Issue 2172023002: chrome/browser/chromeos: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/resource_reporter/resource_reporter.cc
diff --git a/chrome/browser/chromeos/resource_reporter/resource_reporter.cc b/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
index 21906ecb7d3cbac894dd91262d96c3b893a71169..14282018f5b563d641f83dcfcbb6fe748d8929c7 100644
--- a/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
+++ b/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
@@ -327,7 +327,7 @@ const ResourceReporter::TaskRecord* ResourceReporter::SampleTaskByCpu() const {
// See https://en.wikipedia.org/wiki/Reservoir_sampling.
TaskRecord* sampled_task = nullptr;
double cpu_weights_sum = 0;
- for (const auto& task_data : task_records_by_cpu_) {
+ for (auto* task_data : task_records_by_cpu_) {
if ((base::RandDouble() * (cpu_weights_sum + task_data->cpu_percent)) >=
cpu_weights_sum) {
sampled_task = task_data;
@@ -346,7 +346,7 @@ ResourceReporter::SampleTaskByMemory() const {
// See https://en.wikipedia.org/wiki/Reservoir_sampling.
TaskRecord* sampled_task = nullptr;
int64_t memory_weights_sum = 0;
- for (const auto& task_data : task_records_by_memory_) {
+ for (auto* task_data : task_records_by_memory_) {
if ((base::RandDouble() * (memory_weights_sum + task_data->memory_bytes)) >=
memory_weights_sum) {
sampled_task = task_data;
@@ -381,7 +381,7 @@ void ResourceReporter::OnMemoryPressure(
GET_ENUM_VAL(MemoryUsageRange::NUM_RANGES));
// For the rest of tasks, report them using Rappor.
- auto rappor_service = g_browser_process->rappor_service();
+ auto* rappor_service = g_browser_process->rappor_service();
if (!rappor_service)
return;

Powered by Google App Engine
This is Rietveld 408576698