Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/chromeos/policy/upload_job_impl.cc

Issue 2172023002: chrome/browser/chromeos: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/upload_job_impl.cc
diff --git a/chrome/browser/chromeos/policy/upload_job_impl.cc b/chrome/browser/chromeos/policy/upload_job_impl.cc
index 2c567f288ff491450e3453df8e9b144612238613..379624324e67a7e1973d3f10aa85ae041480b5df 100644
--- a/chrome/browser/chromeos/policy/upload_job_impl.cc
+++ b/chrome/browser/chromeos/policy/upload_job_impl.cc
@@ -212,7 +212,7 @@ bool UploadJobImpl::SetUpMultipart() {
std::set<std::string> used_names;
// Check uniqueness of header field names.
- for (const auto& data_segment : data_segments_) {
+ for (auto* data_segment : data_segments_) {
if (!used_names.insert(data_segment->GetName()).second)
return false;
}
@@ -224,7 +224,7 @@ bool UploadJobImpl::SetUpMultipart() {
// allocation more efficient. It is not an error if this turns out to be too
// small as std::string will take care of the realloc.
size_t size = 0;
- for (const auto& data_segment : data_segments_) {
+ for (auto* data_segment : data_segments_) {
for (const auto& entry : data_segment->GetHeaderEntries())
size += entry.first.size() + entry.second.size();
size += kMaxMimeBoundarySize + data_segment->GetName().size() +
@@ -237,7 +237,7 @@ bool UploadJobImpl::SetUpMultipart() {
post_data_.reset(new std::string);
post_data_->reserve(size);
- for (const auto& data_segment : data_segments_) {
+ for (auto* data_segment : data_segments_) {
post_data_->append("--" + *mime_boundary_.get() + "\r\n");
post_data_->append("Content-Disposition: form-data; name=\"" +
data_segment->GetName() + "\"");

Powered by Google App Engine
This is Rietveld 408576698