Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec (Closed)

Created:
4 years, 5 months ago by jsbell
Modified:
4 years, 5 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec FileReader.readAsBinaryString() was removed from the spec after typed arrays became a thing. But all browsers kept shipping it, and it looks risky to remove, so it was added back to the spec. Remove the use counters and TODOs in the IDL files. R=foolip@chromium.org Committed: https://crrev.com/f522563b1a430b66d0e1c61cc9629c04d7550c02 Cr-Commit-Position: refs/heads/master@{#407202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jsbell
Per https://github.com/w3c/FileAPI/issues/39 FileReader.readAsBinaryString() is legit again. foolip@ - can you review?
4 years, 5 months ago (2016-07-21 22:18:43 UTC) #2
foolip
lgtm Yay! Pushing back against spec removals like this is great, even if not *always* ...
4 years, 5 months ago (2016-07-21 22:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171953002/1
4 years, 5 months ago (2016-07-22 17:14:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 18:06:03 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:07:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f522563b1a430b66d0e1c61cc9629c04d7550c02
Cr-Commit-Position: refs/heads/master@{#407202}

Powered by Google App Engine
This is Rietveld 408576698