Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: third_party/WebKit/Source/core/fileapi/FileReader.idl

Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fileapi/FileReaderSync.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 22 matching lines...) Expand all
33 33
34 [ 34 [
35 ActiveScriptWrappable, 35 ActiveScriptWrappable,
36 DependentLifetime, 36 DependentLifetime,
37 Constructor, 37 Constructor,
38 ConstructorCallWith=ExecutionContext, 38 ConstructorCallWith=ExecutionContext,
39 Exposed=(Window,Worker), 39 Exposed=(Window,Worker),
40 ] interface FileReader : EventTarget { 40 ] interface FileReader : EventTarget {
41 // async read methods 41 // async read methods
42 [RaisesException] void readAsArrayBuffer(Blob blob); 42 [RaisesException] void readAsArrayBuffer(Blob blob);
43 // TODO(foolip): readAsBinaryString() was removed from the spec in 2012: 43 [RaisesException] void readAsBinaryString(Blob blob);
44 // https://github.com/w3c/FileAPI/commit/8cce54559dc27bf8b8244f3f0ca9fb3e4d9 6efdb
45 [RaisesException, Measure] void readAsBinaryString(Blob blob);
46 [RaisesException] void readAsText(Blob blob, optional DOMString label); 44 [RaisesException] void readAsText(Blob blob, optional DOMString label);
47 [RaisesException] void readAsDataURL(Blob blob); 45 [RaisesException] void readAsDataURL(Blob blob);
48 46
49 void abort(); 47 void abort();
50 48
51 // states 49 // states
52 const unsigned short EMPTY = 0; 50 const unsigned short EMPTY = 0;
53 const unsigned short LOADING = 1; 51 const unsigned short LOADING = 1;
54 const unsigned short DONE = 2; 52 const unsigned short DONE = 2;
55 53
56 [ImplementedAs=getReadyState] readonly attribute unsigned short readyState; 54 [ImplementedAs=getReadyState] readonly attribute unsigned short readyState;
57 55
58 // File or Blob data 56 // File or Blob data
59 readonly attribute (DOMString or ArrayBuffer)? result; 57 readonly attribute (DOMString or ArrayBuffer)? result;
60 58
61 // TODO(jsbell): Spec has DOMError, which is being deprecated. 59 // TODO(jsbell): Spec has DOMError, which is being deprecated.
62 readonly attribute DOMException? error; 60 readonly attribute DOMException? error;
63 61
64 // event handler attributes 62 // event handler attributes
65 attribute EventHandler onloadstart; 63 attribute EventHandler onloadstart;
66 attribute EventHandler onprogress; 64 attribute EventHandler onprogress;
67 attribute EventHandler onload; 65 attribute EventHandler onload;
68 attribute EventHandler onabort; 66 attribute EventHandler onabort;
69 attribute EventHandler onerror; 67 attribute EventHandler onerror;
70 attribute EventHandler onloadend; 68 attribute EventHandler onloadend;
71 }; 69 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fileapi/FileReaderSync.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698