third_party/WebKit/Source/core/fileapi/FileReaderSync.idl - Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.idl

Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fileapi/FileReaderSync.idl

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderSync.idl b/third_party/WebKit/Source/core/fileapi/FileReaderSync.idl

index 8e9037e749f15e521cfbf124f8b77fca34a25212..8166be3f2a1c6240e7170e048de36dccd31e6d2e 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderSync.idl

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderSync.idl

@@ -35,9 +35,7 @@

Constructor,

] interface FileReaderSync {

[CallWith=ExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);

- // TODO(foolip): readAsBinaryString() was removed from the spec in 2012:

- // https://github.com/w3c/FileAPI/commit/8cce54559dc27bf8b8244f3f0ca9fb3e4d96efdb

- [CallWith=ExecutionContext, RaisesException, Measure] DOMString readAsBinaryString(Blob blob);

+ [CallWith=ExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);

[CallWith=ExecutionContext, RaisesException] DOMString readAsText(Blob blob, optional DOMString label);

[CallWith=ExecutionContext, RaisesException] DOMString readAsDataURL(Blob blob);

};

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReader.idl ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »