third_party/WebKit/Source/core/fileapi/FileReader.idl - Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReader.idl

Issue 2171953002: FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fileapi/FileReader.idl

diff --git a/third_party/WebKit/Source/core/fileapi/FileReader.idl b/third_party/WebKit/Source/core/fileapi/FileReader.idl

index d44da502b4918395d3757c0dba8c95086f83241b..bed069a8775019e5f82391f7f64a686437e5d6fb 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReader.idl

+++ b/third_party/WebKit/Source/core/fileapi/FileReader.idl

@@ -40,9 +40,7 @@

] interface FileReader : EventTarget {

// async read methods

[RaisesException] void readAsArrayBuffer(Blob blob);

- // TODO(foolip): readAsBinaryString() was removed from the spec in 2012:

- // https://github.com/w3c/FileAPI/commit/8cce54559dc27bf8b8244f3f0ca9fb3e4d96efdb

- [RaisesException, Measure] void readAsBinaryString(Blob blob);

+ [RaisesException] void readAsBinaryString(Blob blob);

[RaisesException] void readAsText(Blob blob, optional DOMString label);

[RaisesException] void readAsDataURL(Blob blob);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fileapi/FileReaderSync.idl » ('j') | no next file with comments »