Make sure Widget::dispose() respects UpdateSuspendScope.

Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362
Committed: https://crrev.com/cade7295256e7adabf84272fe5e269834eb44dde
Cr-Commit-Position: refs/heads/master@{#406802}

[dcheng, 2016-07-21 05:59:58]

Description was changed from

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=
==========

to

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362
==========

[dcheng, 2016-07-21 05:59:58]

dcheng@chromium.org changed reviewers:
+ esprehn@chromium.org, sigbjornf@opera.com

[dcheng, 2016-07-21 06:00:49]

This is just a bandaid to fix the immediate fire. In theory, I think this should
work, but it's a bit hard to tell: I'm currently unable to repro the test case
posted in the bug at all, so I'm reaching out to the bug filer atm.

[dcheng, 2016-07-21 06:00:57]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 06:01:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-21 06:18:34]

lgtm, shame there's no test :(

https://codereview.chromium.org/2171683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp (right):

https://codereview.chromium.org/2171683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:107: for (const
auto& widget : set) {
braces aren't needed for the loop if you don't want :)

[dcheng, 2016-07-21 06:20:17]

On 2016/07/21 06:18:34, esprehn wrote:
> lgtm, shame there's no test :(
> 
>
https://codereview.chromium.org/2171683002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp (right):
> 
>
https://codereview.chromium.org/2171683002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:107: for (const
> auto& widget : set) {
> braces aren't needed for the loop if you don't want :)

Yes... we have quite a few plugin related things that need tests.

I'm not going to land this until I hear back from the reporter anyway, so let me
take that time to find my other plugin test IOUs and at least file a bug to
track it.

[commit-bot: I haz the power, 2016-07-21 07:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 07:03:39]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-07-21 07:26:55]

OK, I've confirmed that this patch does fix the issue. CQing (still going to
file a bug to track tests that we're missing)

[dcheng, 2016-07-21 07:55:11]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-07-21 07:55:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:58:49]

Description was changed from

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362
==========

to

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362
==========

[commit-bot: I haz the power, 2016-07-21 07:58:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 08:01:12]

Description was changed from

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362
==========

to

==========
Make sure Widget::dispose() respects UpdateSuspendScope.

BUG=621362

Committed: https://crrev.com/cade7295256e7adabf84272fe5e269834eb44dde
Cr-Commit-Position: refs/heads/master@{#406802}
==========

[commit-bot: I haz the power, 2016-07-21 08:01:13]

Patchset 1 (id:??) landed as
https://crrev.com/cade7295256e7adabf84272fe5e269834eb44dde
Cr-Commit-Position: refs/heads/master@{#406802}