third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h - Issue 2171683002: Make sure Widget::dispose() respects UpdateSuspendScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2171683002: Make sure Widget::dispose() respects UpdateSuspendScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

index 975a9ffbff04d02cfbbdb9d160c952d388494e40..c737a6ae5ce2e9b84875e5081d08f224f9ba2ae1 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

@@ -94,6 +94,8 @@ protected:

bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem);

bool isKeyboardFocusable() const override;

+ void disposeWidgetSoon(Widget*);

private:

// Intentionally private to prevent redundant checks when the type is

// already HTMLFrameOwnerElement.