Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2171683002: Make sure Widget::dispose() respects UpdateSuspendScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 DECLARE_VIRTUAL_TRACE(); 88 DECLARE_VIRTUAL_TRACE();
89 89
90 protected: 90 protected:
91 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&); 91 HTMLFrameOwnerElement(const QualifiedName& tagName, Document&);
92 void setSandboxFlags(SandboxFlags); 92 void setSandboxFlags(SandboxFlags);
93 93
94 bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem); 94 bool loadOrRedirectSubframe(const KURL&, const AtomicString& frameName, bool replaceCurrentItem);
95 bool isKeyboardFocusable() const override; 95 bool isKeyboardFocusable() const override;
96 96
97 void disposeWidgetSoon(Widget*);
98
97 private: 99 private:
98 // Intentionally private to prevent redundant checks when the type is 100 // Intentionally private to prevent redundant checks when the type is
99 // already HTMLFrameOwnerElement. 101 // already HTMLFrameOwnerElement.
100 bool isLocal() const override { return true; } 102 bool isLocal() const override { return true; }
101 bool isRemote() const override { return false; } 103 bool isRemote() const override { return false; }
102 104
103 bool isFrameOwnerElement() const final { return true; } 105 bool isFrameOwnerElement() const final { return true; }
104 106
105 virtual ReferrerPolicy referrerPolicyAttribute() { return ReferrerPolicyDefa ult; } 107 virtual ReferrerPolicy referrerPolicyAttribute() { return ReferrerPolicyDefa ult; }
106 108
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 CORE_EXPORT static SubtreeRootSet& disabledSubtreeRoots(); 148 CORE_EXPORT static SubtreeRootSet& disabledSubtreeRoots();
147 149
148 Member<Node> m_root; 150 Member<Node> m_root;
149 }; 151 };
150 152
151 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, FrameOwner, owner, owner->isLocal(), ow ner.isLocal()); 153 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, FrameOwner, owner, owner->isLocal(), ow ner.isLocal());
152 154
153 } // namespace blink 155 } // namespace blink
154 156
155 #endif // HTMLFrameOwnerElement_h 157 #endif // HTMLFrameOwnerElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698