Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2171683002: Make sure Widget::dispose() respects UpdateSuspendScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
index c48fbe6b0b1492f8f41e49800b154b60cf5ed856..2fd65e7c3b462c88b22deac0db96697e2f0cf9bc 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
@@ -89,7 +89,7 @@ void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)
if (m_persistedPluginWidget) {
if (m_persistedPluginWidget->isPluginView()) {
m_persistedPluginWidget->hide();
- m_persistedPluginWidget->dispose();
+ disposeWidgetSoon(m_persistedPluginWidget.release());
} else {
ASSERT(m_persistedPluginWidget->isFrameView() || m_persistedPluginWidget->isRemoteFrameView());
}

Powered by Google App Engine
This is Rietveld 408576698