cc: Get rid of non-delegated rendering in most cc unit tests.

cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923, 606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6021ec347e80a5e45a25db16bafc307eae6bb643
Cr-Commit-Position: refs/heads/master@{#407280}

[danakj, 2016-07-22 02:16:29]

Description was changed from

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
BUG=421923,606056
==========

to

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-22 02:22:08]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 02:23:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-22 02:23:49]

danakj@chromium.org changed reviewers:
+ miguelg@chromium.org

[danakj, 2016-07-22 02:23:49]

+miguelg@chromium.org for ui/android/

[commit-bot: I haz the power, 2016-07-22 02:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 02:41:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[danakj, 2016-07-22 02:44:04]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 02:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:03:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[danakj, 2016-07-22 18:30:12]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:30:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 19:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:33:56]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2016-07-22 20:24:36]

vmpstr@chromium.org changed reviewers:
+ vmpstr@chromium.org

[vmpstr, 2016-07-22 20:24:37]

lgtm, thanks!

https://codereview.chromium.org/2171143002/diff/50001/cc/layers/layer_unittes...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2171143002/diff/50001/cc/layers/layer_unittes...
cc/layers/layer_unittest.cc:112: LayerSerializationTest() = default;
Do we need an explicit ctor here?

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:76: class LayerTreeHostTest : public
LayerTreeTest {};
Can the below classes directly derive from LayerTreeTest?

[danakj, 2016-07-22 20:34:57]

https://codereview.chromium.org/2171143002/diff/50001/cc/layers/layer_unittes...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2171143002/diff/50001/cc/layers/layer_unittes...
cc/layers/layer_unittest.cc:112: LayerSerializationTest() = default;
On 2016/07/22 20:24:36, vmpstr wrote:
> Do we need an explicit ctor here?

Probly not! I don't see any non-default assignments to the members.

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:76: class LayerTreeHostTest : public
LayerTreeTest {};
On 2016/07/22 20:24:36, vmpstr wrote:
> Can the below classes directly derive from LayerTreeTest?

I've made it a pattern that each file has its own base class, so that when we
want to do something for all the classes in it, we don't have to change the
whole file. I'd like to preserve that here. (It made adding this method that I'm
now deleting easy for example.)

[danakj, 2016-07-22 20:54:59]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-07-22 20:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2171143002/#ps70001
(title: "fakeoutputsurface: no-constructor")

[commit-bot: I haz the power, 2016-07-22 20:55:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-07-22 20:56:34]

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/2171143002/diff/50001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:76: class LayerTreeHostTest : public
LayerTreeTest {};
On 2016/07/22 20:34:57, danakj wrote:
> On 2016/07/22 20:24:36, vmpstr wrote:
> > Can the below classes directly derive from LayerTreeTest?
> 
> I've made it a pattern that each file has its own base class, so that when we
> want to do something for all the classes in it, we don't have to change the
> whole file. I'd like to preserve that here. (It made adding this method that
I'm
> now deleting easy for example.)

Makes sense!

[danakj, 2016-07-22 21:01:39]

Description was changed from

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-22 22:16:23]

Description was changed from

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-22 22:16:24]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-07-22 22:17:58]

Description was changed from

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Get rid of non-delegated rendering in most cc unit tests.

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6021ec347e80a5e45a25db16bafc307eae6bb643
Cr-Commit-Position: refs/heads/master@{#407280}
==========

[commit-bot: I haz the power, 2016-07-22 22:17:59]

Patchset 5 (id:??) landed as
https://crrev.com/6021ec347e80a5e45a25db16bafc307eae6bb643
Cr-Commit-Position: refs/heads/master@{#407280}