cc/layers/ui_resource_layer_impl_unittest.cc - Issue 2171143002: cc: Get rid of non-delegated rendering in most cc unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/ui_resource_layer_impl_unittest.cc

Issue 2171143002: cc: Get rid of non-delegated rendering in most cc unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@killdirecttests

Patch Set: fakeoutputsurface: no-constructor Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/ui_resource_layer_impl_unittest.cc

diff --git a/cc/layers/ui_resource_layer_impl_unittest.cc b/cc/layers/ui_resource_layer_impl_unittest.cc

index b86fadaca2f2d56466d1b4d97a86aa0c3f22b084..67a986de0040d2a8702c9f9f23946c4284cba1c6 100644

--- a/cc/layers/ui_resource_layer_impl_unittest.cc

+++ b/cc/layers/ui_resource_layer_impl_unittest.cc

@@ -61,7 +61,8 @@ TEST(UIResourceLayerImplTest, VerifyDrawQuads) {

FakeImplTaskRunnerProvider task_runner_provider;

TestSharedBitmapManager shared_bitmap_manager;

TestTaskGraphRunner task_graph_runner;

- std::unique_ptr<OutputSurface> output_surface = FakeOutputSurface::Create3d();

+ std::unique_ptr<OutputSurface> output_surface =

+ FakeOutputSurface::CreateDelegating3d();

FakeUIResourceLayerTreeHostImpl host_impl(

&task_runner_provider, &shared_bitmap_manager, &task_graph_runner);

host_impl.SetVisible(true);

@@ -106,7 +107,8 @@ TEST(UIResourceLayerImplTest, VerifySetOpaqueOnSkBitmap) {

FakeImplTaskRunnerProvider task_runner_provider;

TestSharedBitmapManager shared_bitmap_manager;

TestTaskGraphRunner task_graph_runner;

- std::unique_ptr<OutputSurface> output_surface = FakeOutputSurface::Create3d();

+ std::unique_ptr<OutputSurface> output_surface =

+ FakeOutputSurface::CreateDelegating3d();

FakeUIResourceLayerTreeHostImpl host_impl(

&task_runner_provider, &shared_bitmap_manager, &task_graph_runner);

host_impl.SetVisible(true);

@@ -135,7 +137,8 @@ TEST(UIResourceLayerImplTest, VerifySetOpaqueOnLayer) {

FakeImplTaskRunnerProvider task_runner_provider;

TestSharedBitmapManager shared_bitmap_manager;

TestTaskGraphRunner task_graph_runner;

- std::unique_ptr<OutputSurface> output_surface = FakeOutputSurface::Create3d();

+ std::unique_ptr<OutputSurface> output_surface =

+ FakeOutputSurface::CreateDelegating3d();

FakeUIResourceLayerTreeHostImpl host_impl(

&task_runner_provider, &shared_bitmap_manager, &task_graph_runner);

host_impl.SetVisible(true);

« no previous file with comments | « cc/layers/texture_layer_unittest.cc ('k') | cc/layers/ui_resource_layer_unittest.cc » ('j') | no next file with comments »