Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: cc/layers/surface_layer_unittest.cc

Issue 2171143002: cc: Get rid of non-delegated rendering in most cc unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@killdirecttests
Patch Set: fakeoutputsurface: no-constructor Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/solid_color_layer_impl_unittest.cc ('k') | cc/layers/texture_layer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/surface_layer_unittest.cc
diff --git a/cc/layers/surface_layer_unittest.cc b/cc/layers/surface_layer_unittest.cc
index 4471fa5223442eb101681eb3bff27624342c7cd4..5f40debf305e4484279b573d5f3133f240af27cb 100644
--- a/cc/layers/surface_layer_unittest.cc
+++ b/cc/layers/surface_layer_unittest.cc
@@ -29,11 +29,6 @@ namespace {
static constexpr uint32_t kArbitraryClientId = 0;
class SurfaceLayerTest : public testing::Test {
- public:
- SurfaceLayerTest()
- : fake_client_(
- FakeLayerTreeHostClient(FakeLayerTreeHostClient::DIRECT_3D)) {}
-
protected:
void SetUp() override {
layer_tree_host_ =
@@ -182,8 +177,7 @@ class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
SurfaceLayerSwapPromiseWithDraw() : SurfaceLayerSwapPromise() {}
std::unique_ptr<OutputSurface> CreateOutputSurface() override {
- auto ret = delegating_renderer() ? FakeOutputSurface::CreateDelegating3d()
- : FakeOutputSurface::Create3d();
+ auto ret = FakeOutputSurface::CreateDelegating3d();
output_surface_ = ret.get();
return std::move(ret);
}
@@ -229,9 +223,7 @@ class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
FakeOutputSurface* output_surface_;
};
-// TODO(jbauman): Reenable on single thread once http://crbug.com/421923 is
-// fixed.
-MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw);
+SINGLE_AND_MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw);
// Check that SurfaceSequence is sent through swap promise and resolved when
// swap fails.
« no previous file with comments | « cc/layers/solid_color_layer_impl_unittest.cc ('k') | cc/layers/texture_layer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698