cc: Break up with FakeLayerTreeHostClient.

cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ffc181a212a047aaaa8e653c759d51d25eb3c71c
Cr-Commit-Position: refs/heads/master@{#407288}

[danakj, 2016-07-22 03:38:27]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne
BUG=606056
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-22 03:38:30]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 03:39:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-22 03:39:25]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-22 03:39:25]

danakj@chromium.org changed reviewers:
+ dtrainor@chromium.org

[danakj, 2016-07-22 03:39:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 03:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:43:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[danakj, 2016-07-22 18:45:15]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 19:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:12:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-07-22 21:05:57]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:06:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-22 21:06:54]

danakj@chromium.org changed reviewers:
+ miguelc@chromium.org

[danakj, 2016-07-22 21:07:03]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelc
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-22 21:07:17]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelc
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-22 21:07:17]

danakj@chromium.org changed reviewers:
+ miguelg@chromium.org
- miguelc@chromium.org

[vmpstr, 2016-07-22 21:08:41]

vmpstr@chromium.org changed reviewers:
+ miguelc@chromium.org, vmpstr@chromium.org
- miguelg@chromium.org

[vmpstr, 2016-07-22 21:08:43]

This looks good, I just had some clarifying questions. Maybe what is confusing
to me is the names

FakeLayerTreeHostClient vs StubLayerTreeHostSingleThreadClient sounds like they
implement the same interface just one is a fake one is a stub for single thread
version. This makes me question anytime I see both of them used to
initialize/create the same object

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/layer_unittes...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/layer_unittes...
cc/layers/layer_unittest.cc:923: new
StrictMock<MockLayerTreeHost>(&single_thread_client_, &params));
It's a bit inconsistent that we pass a single_thread_client_ here, but
params.client refers to fake_client_. What's up with that? I _think_ that's the
only reference to this fake_client_ in this file

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
cc/layers/picture_layer_impl_unittest.cc:25: #include
"cc/test/fake_layer_tree_host.h"
Is this pure IWYU or was it pulling the classes from somewhere else that is no
longer accessible?

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
File cc/layers/picture_layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
cc/layers/picture_layer_unittest.cc:488:
LayerTreeHost::CreateSingleThreaded(&single_thread_client, &params);
I guess similar question here (and elsewhere) about single_thread_client vs
params.client

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
File cc/layers/texture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
cc/layers/texture_layer_impl_unittest.cc:14: #include
"gpu/command_buffer/client/gles2_interface.h"
Why is this needed?

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
File cc/layers/texture_layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
cc/layers/texture_layer_unittest.cc:88:
MockLayerTreeHost(FakeLayerTreeHostClient* client,
not used anymore?

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/ui_resource_l...
File cc/layers/ui_resource_layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/ui_resource_l...
cc/layers/ui_resource_layer_unittest.cc:52:
FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_);
hmm.. fake_client_? I think I might be missing something :)

[danakj, 2016-07-22 21:19:30]

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/layer_unittes...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/layer_unittes...
cc/layers/layer_unittest.cc:923: new
StrictMock<MockLayerTreeHost>(&single_thread_client_, &params));
On 2016/07/22 21:08:42, vmpstr wrote:
> It's a bit inconsistent that we pass a single_thread_client_ here, but
> params.client refers to fake_client_. What's up with that? I _think_ that's
the
> only reference to this fake_client_ in this file

LTHClient and LTHSingleThreadClient are 2 diff interfaces. They used to both be
implemented by FakeLTHClient. I'm breaking it up into 2 stubs. And then
FakeLTHClient is now simply a LTHClient *only*, for use by FakeLTH.

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/picture_layer...
cc/layers/picture_layer_impl_unittest.cc:25: #include
"cc/test/fake_layer_tree_host.h"
On 2016/07/22 21:08:42, vmpstr wrote:
> Is this pure IWYU or was it pulling the classes from somewhere else that is no
> longer accessible?

Yes IWYU.

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
File cc/layers/texture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
cc/layers/texture_layer_impl_unittest.cc:14: #include
"gpu/command_buffer/client/gles2_interface.h"
On 2016/07/22 21:08:43, vmpstr wrote:
> Why is this needed?

IWYU fix.

[danakj, 2016-07-22 21:21:20]

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
File cc/layers/texture_layer_unittest.cc (right):

https://codereview.chromium.org/2174653002/diff/40001/cc/layers/texture_layer...
cc/layers/texture_layer_unittest.cc:88:
MockLayerTreeHost(FakeLayerTreeHostClient* client,
On 2016/07/22 21:08:43, vmpstr wrote:
> not used anymore?

Done.

[danakj, 2016-07-22 21:22:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-07-22 21:28:03]

Thanks for the explanation. I was a bit confused but it was because of our
non-test interface names, not because of this patch. I now understand that this
aligns it better to mimic the non test code where we have explicit two different
interfaces. lgtm.

[danakj, 2016-07-22 22:17:01]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-07-22 22:17:05]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:17:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-07-22 22:26:48]

Sorry for the delayed reply.  lgtm as well :).

[commit-bot: I haz the power, 2016-07-22 22:48:59]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-22 22:49:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-22 22:50:36]

Description was changed from

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Break up with FakeLayerTreeHostClient.

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ffc181a212a047aaaa8e653c759d51d25eb3c71c
Cr-Commit-Position: refs/heads/master@{#407288}
==========

[commit-bot: I haz the power, 2016-07-22 22:50:38]

Patchset 5 (id:??) landed as
https://crrev.com/ffc181a212a047aaaa8e653c759d51d25eb3c71c
Cr-Commit-Position: refs/heads/master@{#407288}