Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2169973002: Add bundle_deps to ios_{app,framework}_bundle templates. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
*Dirk Pranke, *justincohen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios-app-bundle-executable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bundle_deps to ios_{app,framework}_bundle templates. Allow to specify dependencies that are only used by the create_bundle target when using ios_app_bundle or ios_framework_bundle templates to increase parallelism. BUG=629867 Committed: https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9 Cr-Commit-Position: refs/heads/master@{#407102}

Patch Set 1 #

Patch Set 2 : Fix compilation of fat builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M build/config/ios/rules.gni View 1 4 chunks +8 lines, -0 lines 0 comments Download
M build/config/mac/base_rules.gni View 4 chunks +10 lines, -0 lines 0 comments Download
M components/cronet/ios/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M testing/test.gni View 2 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
sdefresne
Please take a look. justincohen : look at everything. dpranke: OWNERS approval for testing/test.gni
4 years, 5 months ago (2016-07-21 18:13:11 UTC) #5
justincohen
lgtm
4 years, 5 months ago (2016-07-21 18:29:07 UTC) #6
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 20:41:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169973002/20001
4 years, 5 months ago (2016-07-22 08:01:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 08:49:48 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 08:51:04 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/047490e7bb0d5c4ef2862a7059931fdec4e69ce9
Cr-Commit-Position: refs/heads/master@{#407102}

Powered by Google App Engine
This is Rietveld 408576698