Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2164393002: Add Info.plist support to ios_framework_bundle template. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bundle-deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Info.plist support to ios_framework_bundle template. iOS framework requires a valid Info.plist file, so add support for generating it to ios_framework_bundle template. BUG=629867 Committed: https://crrev.com/4edf6105b4fc4b98d12b23d8bf74e96d130dce54 Cr-Commit-Position: refs/heads/master@{#407127}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and fix compilation of fat builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -47 lines) Patch
M build/config/ios/rules.gni View 1 2 chunks +34 lines, -0 lines 0 comments Download
M build/config/mac/base_rules.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/ios/BUILD.gn View 2 chunks +1 line, -23 lines 0 comments Download
M ios/third_party/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/third_party/earl_grey/Info.plist View 1 chunk +12 lines, -12 lines 0 comments Download
M ios/third_party/ochamcrest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/third_party/ochamcrest/Info.plist View 1 chunk +12 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-21 18:15:10 UTC) #3
justincohen
https://codereview.chromium.org/2164393002/diff/1/ios/third_party/earl_grey/Info.plist File ios/third_party/earl_grey/Info.plist (right): https://codereview.chromium.org/2164393002/diff/1/ios/third_party/earl_grey/Info.plist#newcode17 ios/third_party/earl_grey/Info.plist:17: <key>CFBundleDevelopmentRegion</key> Why did this sort change? https://codereview.chromium.org/2164393002/diff/1/ios/third_party/ochamcrest/Info.plist File ios/third_party/ochamcrest/Info.plist ...
4 years, 5 months ago (2016-07-21 18:32:41 UTC) #7
sdefresne
On 2016/07/21 18:32:41, justincohen wrote: > https://codereview.chromium.org/2164393002/diff/1/ios/third_party/earl_grey/Info.plist > File ios/third_party/earl_grey/Info.plist (right): > > https://codereview.chromium.org/2164393002/diff/1/ios/third_party/earl_grey/Info.plist#newcode17 > ...
4 years, 5 months ago (2016-07-22 08:57:20 UTC) #10
justincohen
lgtm
4 years, 5 months ago (2016-07-22 10:50:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164393002/20001
4 years, 5 months ago (2016-07-22 10:51:10 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 10:55:17 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:56:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4edf6105b4fc4b98d12b23d8bf74e96d130dce54
Cr-Commit-Position: refs/heads/master@{#407127}

Powered by Google App Engine
This is Rietveld 408576698