Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2167933003: Keep ios_app_bundle final executable target name unchanged in fat builds. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios-sdk-platform-path
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep ios_app_bundle final executable target name unchanged in fat builds. Keep the name of the target generating the executable in ios_app_bundle template the same whether the final binary is a fat or thin binary. BUG=629867 Committed: https://crrev.com/dd0360b2ab164da9e527e32f6d602b9e22f21b06 Cr-Commit-Position: refs/heads/master@{#407095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/config/ios/rules.gni View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-21 18:09:51 UTC) #4
justincohen
lgtm
4 years, 5 months ago (2016-07-21 18:26:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167933003/1
4 years, 5 months ago (2016-07-22 07:51:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 07:54:27 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 07:57:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd0360b2ab164da9e527e32f6d602b9e22f21b06
Cr-Commit-Position: refs/heads/master@{#407095}

Powered by Google App Engine
This is Rietveld 408576698