components/cronet/ios/BUILD.gn - Issue 2169973002: Add bundle_deps to ios_{app,framework}_bundle templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/BUILD.gn

Issue 2169973002: Add bundle_deps to ios_{app,framework}_bundle templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-app-bundle-executable

Patch Set: Fix compilation of fat builds. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/ios/BUILD.gn

diff --git a/components/cronet/ios/BUILD.gn b/components/cronet/ios/BUILD.gn

index d614a093105db9852229a794b08b45dd1f8729c8..01c445b8e9a1897535d5f35c019e0f2e8f3a2729 100644

--- a/components/cronet/ios/BUILD.gn

+++ b/components/cronet/ios/BUILD.gn

@@ -70,7 +70,7 @@ ios_info_plist("compile_cronet_plist") {

# Bundle plist into Cronet.Framework.

bundle_data("cronet_info_plist") {

- deps = [

+ public_deps = [

":compile_cronet_plist",

]

@@ -86,13 +86,13 @@ ios_framework_bundle("cronet_framework") {

output_name = "Cronet"

deps = [

- ":compile_cronet_plist",

- ":cronet_info_plist",

":cronet_sources",

"//base",

"//net:net",

]

+ bundle_deps = [ ":cronet_info_plist" ]

libs = [ "UIKit.Framework" ]

public_headers = [

« no previous file with comments | « build/config/mac/base_rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »