Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2169273002: [Mac/GN] Fix all the //remoting Info.plist substitutions. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Fix all the //remoting Info.plist substitutions. BUG=628686 R=nicholss@chromium.org,sergeyu@chromium.org Committed: https://crrev.com/c311f11649393ec89cc92a1958ca92b2fd27d7f7 Cr-Commit-Position: refs/heads/master@{#407338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -43 lines) Patch
M build/util/version.gni View 2 chunks +1 line, -6 lines 0 comments Download
M remoting/host/BUILD.gn View 5 chunks +34 lines, -4 lines 0 comments Download
M remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/host/it2me/remote_assistance_host-Info.plist View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane-Info.plist View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/remoting_me2me_host-Info.plist View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/setup/native_messaging_host-Info.plist View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_host.gypi View 3 chunks +9 lines, -6 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/remoting_version.gni View 3 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
Robert Sesek
4 years, 5 months ago (2016-07-22 01:54:30 UTC) #3
Sergey Ulanov
lgtm
4 years, 5 months ago (2016-07-22 19:49:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169273002/40001
4 years, 5 months ago (2016-07-22 21:58:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/223717)
4 years, 5 months ago (2016-07-22 22:06:58 UTC) #18
Robert Sesek
+dpranke for OWNERS
4 years, 5 months ago (2016-07-22 23:55:43 UTC) #20
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-23 00:57:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169273002/40001
4 years, 5 months ago (2016-07-23 02:18:13 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-23 03:36:29 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 03:38:15 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c311f11649393ec89cc92a1958ca92b2fd27d7f7
Cr-Commit-Position: refs/heads/master@{#407338}

Powered by Google App Engine
This is Rietveld 408576698