remoting/host/it2me/BUILD.gn - Issue 2169273002: [Mac/GN] Fix all the //remoting Info.plist substitutions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/it2me/BUILD.gn

Issue 2169273002: [Mac/GN] Fix all the //remoting Info.plist substitutions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist ('k') | remoting/host/it2me/remote_assistance_host-Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/it2me/BUILD.gn

diff --git a/remoting/host/it2me/BUILD.gn b/remoting/host/it2me/BUILD.gn

index dac44d3dfa7b22b12a4f3d7473a2cfcf038fbf6a..e97e871e2a3fd762dae5c7577ce60045a2bbf9a6 100644

--- a/remoting/host/it2me/BUILD.gn

+++ b/remoting/host/it2me/BUILD.gn

@@ -6,6 +6,7 @@ import("//build/config/features.gni")

import("//remoting/remoting_enable.gni")

import("//remoting/remoting_srcs.gni")

import("//remoting/remoting_locales.gni")

+import("//remoting/remoting_version.gni")

if (is_win) {

import("//remoting/host/predefines_win.gni")

@@ -119,6 +120,12 @@ if (!is_chromeos && !is_android && enable_remoting_host) {

target(app_target_type, "remote_assistance_host") {

if (is_mac) {

info_plist = "remote_assistance_host-Info.plist"

+ extra_substitutions = [

+ "BUNDLE_ID=$remote_assistance_host_bundle_id",

+ "VERSION_FULL=$remoting_version_full",

+ "VERSION_SHORT=$remoting_version_short",

+ "MACOSX_DEPLOYMENT_TARGET=10.7",

+ ]

extra_configs = [

"//build/config/compiler:wexit_time_destructors",

"//remoting:version",