Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/remoting_host.gypi

Issue 2169273002: [Mac/GN] Fix all the //remoting Info.plist substitutions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/setup/native_messaging_host-Info.plist ('k') | remoting/remoting_host_mac.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_host.gypi
diff --git a/remoting/remoting_host.gypi b/remoting/remoting_host.gypi
index 57b3e93662645bbdca0504a11f7767fce36df1be..8b670e6a5312a2978a00a962507e7445b360e3cd 100644
--- a/remoting/remoting_host.gypi
+++ b/remoting/remoting_host.gypi
@@ -474,8 +474,9 @@
},
'xcode_settings': {
'INFOPLIST_FILE': 'host/remoting_me2me_host-Info.plist',
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(host_bundle_id)"',
+ 'VERSION_FULL': '<(version_full)',
+ 'VERSION_SHORT': '<(version_short)',
+ 'BUNDLE_ID': '<(host_bundle_id)',
},
'mac_bundle_resources': [
'<(PRODUCT_DIR)/icudtl.dat',
@@ -559,8 +560,9 @@
},
'xcode_settings': {
'INFOPLIST_FILE': 'host/setup/native_messaging_host-Info.plist',
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(host_bundle_id)"',
+ 'VERSION_FULL': '<(version_full)',
+ 'VERSION_SHORT': '<(version_short)',
+ 'BUNDLE_ID': '<(host_bundle_id)',
},
'mac_bundle_resources': [
'host/setup/native_messaging_host-Info.plist',
@@ -672,8 +674,9 @@
},
'xcode_settings': {
'INFOPLIST_FILE': 'host/it2me/remote_assistance_host-Info.plist',
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(host_bundle_id)"',
+ 'VERSION_FULL': '<(version_full)',
+ 'VERSION_SHORT': '<(version_short)',
+ 'BUNDLE_ID': '<(host_bundle_id)',
},
'mac_bundle_resources': [
'<(PRODUCT_DIR)/icudtl.dat',
« no previous file with comments | « remoting/host/setup/native_messaging_host-Info.plist ('k') | remoting/remoting_host_mac.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698