Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: remoting/remoting_host_mac.gypi

Issue 2169273002: [Mac/GN] Fix all the //remoting Info.plist substitutions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_host.gypi ('k') | remoting/remoting_version.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_host_mac.gypi
diff --git a/remoting/remoting_host_mac.gypi b/remoting/remoting_host_mac.gypi
index fb03e28226435b3339a2c4166f4d39b8c182d812..db9bea8f3517eb530c9228667de733e2e0ebcad0 100644
--- a/remoting/remoting_host_mac.gypi
+++ b/remoting/remoting_host_mac.gypi
@@ -52,8 +52,9 @@
],
'xcode_settings': {
'INFOPLIST_FILE': 'host/installer/mac/uninstaller/remoting_uninstaller-Info.plist',
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(bundle_id)"',
+ 'VERSION_FULL': '<(version_full)',
+ 'VERSION_SHORT': '<(version_short)',
+ 'BUNDLE_ID': '<(bundle_id)',
},
'mac_bundle_resources': [
'host/installer/mac/uninstaller/remoting_uninstaller.icns',
@@ -212,8 +213,9 @@
'xcode_settings': {
'GCC_ENABLE_OBJC_GC': 'supported',
'INFOPLIST_FILE': 'host/mac/me2me_preference_pane-Info.plist',
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(bundle_id)"',
+ 'VERSION_FULL': '<(version_full)',
+ 'VERSION_SHORT': '<(version_short)',
+ 'BUNDLE_ID': '<(bundle_id)',
},
'mac_bundle_resources': [
'host/mac/me2me_preference_pane.xib',
« no previous file with comments | « remoting/remoting_host.gypi ('k') | remoting/remoting_version.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698