|
Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )
Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.
BUG= 628554, 628605, 628662, 630191
Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a95281959d1b4dd941fed10998adf8dcb63c.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo (crbug.com/543946)
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG= 240576, 543946
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}
TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 240576, 543946
Committed: https://crrev.com/87365b3f6c6293bac8a2513cef257d8e2cb0898a
Cr-Commit-Position: refs/heads/master@{#407089}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+584 lines, -445 lines) |
Patch |
 |
M |
third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
|
View
|
1
|
2 chunks |
+1 line, -9 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
|
View
|
|
1 chunk |
+56 lines, -51 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
|
View
|
|
1 chunk |
+11 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
|
View
|
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop.html
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-expected.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe.html
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-iframe-expected.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video.html
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-video-expected.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/overflow.html
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/rendering/overflow-root.html
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/resources/green.html
|
View
|
|
1 chunk |
+8 lines, -2 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/fullscreen/resources/white.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/virtual/android/fullscreen/rendering/backdrop-video-expected.html
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/core.gypi
|
View
|
1
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/fullscreen.css
|
View
|
1
|
1 chunk |
+47 lines, -30 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/html.css
|
View
|
1
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
|
View
|
1
|
2 chunks |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
|
View
|
1
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Document.h
|
View
|
1
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Document.cpp
|
View
|
1
|
1 chunk |
+3 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Fullscreen.h
|
View
|
1
|
4 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/Fullscreen.cpp
|
View
|
1
|
9 chunks |
+51 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
|
View
|
1
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/dom/PseudoElement.cpp
|
View
|
1
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/frame/FrameView.cpp
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutBlock.cpp
|
View
|
1
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutBox.h
|
View
|
1
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
A + |
third_party/WebKit/Source/core/layout/LayoutFullScreen.h
|
View
|
1
|
2 chunks |
+30 lines, -34 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
|
View
|
1
|
1 chunk |
+206 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutInline.cpp
|
View
|
1
|
2 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutObject.h
|
View
|
1
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutVideo.h
|
View
|
1
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/LayoutVideo.cpp
|
View
|
1
|
2 chunks |
+43 lines, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/core/layout/api/LayoutFullScreenItem.h
|
View
|
1
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/layout/api/LayoutItem.h
|
View
|
1
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/FullscreenController.cpp
|
View
|
1
|
4 chunks |
+4 lines, -17 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/tests/WebFrameTest.cpp
|
View
|
1
|
4 chunks |
+4 lines, -38 lines |
0 comments
|
Download
|
Total messages: 14 (6 generated)
|