third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2168373002: Revert of Reland "Implement FullScreen using top layer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2168373002: Revert of Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve WebFrameTest.cpp conflict and appease presubmit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 687b58d8451b0789bb81f5d439dc29cfbdc80004..cd8d50e62b6f53c0f6684c50a029f145fb2db5cb 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1798,7 +1798,8 @@ void FrameView::clearLayoutSubtreeRootsAndMarkContainingBlocks()

void FrameView::addOrthogonalWritingModeRoot(LayoutBox& root)

{

- DCHECK(!root.isLayoutScrollbarPart());

+ DCHECK(!root.isLayoutFullScreen() && !root.isLayoutFullScreenPlaceholder()

+ && !root.isLayoutScrollbarPart());

m_orthogonalWritingModeRootList.add(root);

}

« no previous file with comments | « third_party/WebKit/Source/core/dom/PseudoElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »