Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2168373002: Revert of Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolve WebFrameTest.cpp conflict and appease presubmit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/FullscreenController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 142b51a4ca8140cb6d43336340496d05578b9ac5..3b224ef7f48be51217a46190c3ae20afdb1d80d4 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -64,6 +64,8 @@
#include "core/html/ImageDocument.h"
#include "core/input/EventHandler.h"
#include "core/layout/HitTestResult.h"
+#include "core/layout/LayoutFullScreen.h"
+#include "core/layout/api/LayoutViewItem.h"
#include "core/layout/compositing/PaintLayerCompositor.h"
#include "core/loader/DocumentLoader.h"
#include "core/loader/DocumentThreadableLoader.h"
@@ -6434,40 +6436,6 @@ TEST_F(WebFrameTest, MaximumScrollPositionCanBeNegative)
EXPECT_LT(frameView->maximumScrollPosition().x(), 0);
}
-TEST_F(WebFrameTest, FullscreenCleanTopLayerAndFullscreenStack)
-{
- FakeCompositingWebViewClient client;
- registerMockedHttpURLLoad("fullscreen_div.html");
- FrameTestHelpers::WebViewHelper webViewHelper;
- int viewportWidth = 640;
- int viewportHeight = 480;
- client.m_screenInfo.rect.width = viewportWidth;
- client.m_screenInfo.rect.height = viewportHeight;
- WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(
- m_baseURL + "fullscreen_div.html", true, 0, &client, nullptr, configureAndroid);
- webViewImpl->resize(WebSize(viewportWidth, viewportHeight));
- webViewImpl->updateAllLifecyclePhases();
-
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
- Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- Fullscreen& fullscreen = Fullscreen::from(*document);
-
- Element* divFullscreen = document->getElementById("div1");
- fullscreen.requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
- webViewImpl->didEnterFullscreen();
- ASSERT_TRUE(Fullscreen::isFullScreen(*document));
-
- // Sanity check. We should have both in our stack.
- ASSERT_EQ(fullscreen.fullScreenElementStack().size(), 1UL);
- ASSERT_EQ(document->topLayerElements().size(), 2UL);
-
- fullscreen.exitFullscreen();
- webViewImpl->didExitFullscreen();
-
- ASSERT_EQ(fullscreen.fullScreenElementStack().size(), 0UL);
- ASSERT_EQ(document->topLayerElements().size(), 0UL);
-}
-
TEST_P(ParameterizedWebFrameTest, FullscreenLayerSize)
{
FakeCompositingWebViewClient client;
@@ -6490,8 +6458,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenLayerSize)
ASSERT_TRUE(Fullscreen::isFullScreen(*document));
// Verify that the element is sized to the viewport.
- Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
- LayoutBox* fullscreenLayoutObject = toLayoutBox(fullscreenElement->layoutObject());
+ LayoutFullScreen* fullscreenLayoutObject = Fullscreen::from(*document).fullScreenLayoutObject();
EXPECT_EQ(viewportWidth, fullscreenLayoutObject->logicalWidth().toInt());
EXPECT_EQ(viewportHeight, fullscreenLayoutObject->logicalHeight().toInt());
@@ -6595,8 +6562,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenSubframe)
webViewImpl->updateAllLifecyclePhases();
// Verify that the element is sized to the viewport.
- Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
- LayoutBox* fullscreenLayoutObject = toLayoutBox(fullscreenElement->layoutObject());
+ LayoutFullScreen* fullscreenLayoutObject = Fullscreen::from(*document).fullScreenLayoutObject();
EXPECT_EQ(viewportWidth, fullscreenLayoutObject->logicalWidth().toInt());
EXPECT_EQ(viewportHeight, fullscreenLayoutObject->logicalHeight().toInt());
« no previous file with comments | « third_party/WebKit/Source/web/FullscreenController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698