third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html - Issue 2168373002: Revert of Reland "Implement FullScreen using top layer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html

Issue 2168373002: Revert of Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve WebFrameTest.cpp conflict and appease presubmit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html ('k') | third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html

diff --git a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html b/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html

index 0d898c9dd22ac25a2739fa672178716dd807106b..0ae491e8398e5630e2570e75c4fc54fb426ad8fb 100644

--- a/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html

+++ b/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-ua-style.html

@@ -5,16 +5,18 @@

document.offsetWidth;

frame.contentDocument.offsetWidth;

var videoEnteredFullScreen = function() {

- test("getComputedStyle(document.documentElement).overflow == 'hidden'");

+ test("getComputedStyle(ancestor).position == 'static'");

endTest();

};

waitForEvent(frame.contentDocument, "webkitfullscreenchange", videoEnteredFullScreen);

- test("getComputedStyle(document.documentElement).overflow == 'visible'");

+ test("getComputedStyle(ancestor).position == 'relative'");

runWithKeyDown(function(){

frame.contentDocument.querySelector("video").webkitRequestFullScreen();

});

}

</script>

-<iframe allowfullscreen id="frame" src="data:text/html,<video></video>" onload="runTest()"></iframe>

+<div id="ancestor" style="position:relative">

+ <iframe allowfullscreen id="frame" src="data:text/html,<video></video>" onload="runTest()"></iframe>

+</div>