Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2168873003: Query sdk-platform-path in build/config/mac/sdk_info.py. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Query sdk-platform-path in build/config/mac/sdk_info.py. The XCTest support (used for EarlGrey tests) requires linking against XCTest.framework whose location is relative to sdk-platform-path, so propagate via ios_sdk_platform_path variable in gn. BUG=629867 Committed: https://crrev.com/4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4 Cr-Commit-Position: refs/heads/master@{#407093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/ios/ios_sdk.gni View 2 chunks +2 lines, -0 lines 0 comments Download
M build/config/mac/sdk_info.py View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-21 18:04:16 UTC) #3
justincohen
lgtm
4 years, 5 months ago (2016-07-21 18:08:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168873003/1
4 years, 5 months ago (2016-07-22 07:42:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 07:45:51 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 07:47:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eba1aaa77f9e89b2b1cdf117a7e6fd8175436e4
Cr-Commit-Position: refs/heads/master@{#407093}

Powered by Google App Engine
This is Rietveld 408576698