Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: build/config/ios/rules.gni

Issue 2167933003: Keep ios_app_bundle final executable target name unchanged in fat builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-sdk-platform-path
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 import("//build/config/mac/base_rules.gni") 6 import("//build/config/mac/base_rules.gni")
7 import("//build/config/mac/symbols.gni") 7 import("//build/config/mac/symbols.gni")
8 8
9 # Generates Info.plist files for Mac apps and frameworks. 9 # Generates Info.plist files for Mac apps and frameworks.
10 # 10 #
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 forward_variables_from(invoker, [ "testonly" ]) 204 forward_variables_from(invoker, [ "testonly" ])
205 sources = get_target_outputs(":$_generate_info_plist") 205 sources = get_target_outputs(":$_generate_info_plist")
206 outputs = [ 206 outputs = [
207 "{{bundle_root_dir}}/Info.plist", 207 "{{bundle_root_dir}}/Info.plist",
208 ] 208 ]
209 public_deps = [ 209 public_deps = [
210 ":$_generate_info_plist", 210 ":$_generate_info_plist",
211 ] 211 ]
212 } 212 }
213 213
214 _link_executable = _target_name + "_link_executable" 214 _link_executable = _target_name + "_executable"
215 _executable_path = "$target_out_dir/$_output_name" 215 _executable_path = "$target_out_dir/$_output_name"
216 216
217 if (ios_enable_code_signing) { 217 if (ios_enable_code_signing) {
218 _link_executable_visibility = [ ":$_target_name" ] 218 _link_executable_visibility = [ ":$_target_name" ]
219 } else { 219 } else {
220 _bundle_data_executable = target_name + "_bundle_data_executable" 220 _bundle_data_executable = target_name + "_bundle_data_executable"
221 _link_executable_visibility = [ ":$_bundle_data_executable" ] 221 _link_executable_visibility = [ ":$_bundle_data_executable" ]
222 } 222 }
223 223
224 # For a fat-build, the different "executable" outputs will be used to 224 # For a fat-build, the different "executable" outputs will be used to
225 # create the final binary using "lipo". As the corresponding target has 225 # create the final binary using "lipo". As the corresponding target has
226 # the same role as the "executable" target in a thin build, copy the 226 # the same role as the "executable" target in a thin build, copy the
227 # visibility and redefine some variables. 227 # visibility and redefine some variables.
228 if (_is_fat_build) { 228 if (_is_fat_build) {
229 _lipo_executable = _target_name + "_lipo_executable" 229 _lipo_executable = _link_executable
230 _lipo_executable_visibility = _link_executable_visibility 230 _lipo_executable_visibility = _link_executable_visibility
231 231
232 _link_executable_visibility = [] 232 _link_executable_visibility = []
233 _link_executable_visibility = [ ":$_lipo_executable" ] 233 _link_executable_visibility = [ ":$_lipo_executable" ]
234 _link_executable = _target_name + "_arch_executable"
234 235
235 _arch_executable_path = "$target_out_dir/$current_cpu/$_output_name" 236 _arch_executable_path = "$target_out_dir/$current_cpu/$_output_name"
236 } 237 }
237 238
238 executable(_link_executable) { 239 executable(_link_executable) {
239 forward_variables_from(invoker, 240 forward_variables_from(invoker,
240 "*", 241 "*",
241 [ 242 [
242 "bundle_extension", 243 "bundle_extension",
243 "data_deps", 244 "data_deps",
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 public_deps = [ 849 public_deps = [
849 ":$_framework_target+link$_toolchain_suffix", 850 ":$_framework_target+link$_toolchain_suffix",
850 ] 851 ]
851 } 852 }
852 } 853 }
853 } 854 }
854 855
855 set_defaults("ios_framework_bundle") { 856 set_defaults("ios_framework_bundle") {
856 configs = default_shared_library_configs 857 configs = default_shared_library_configs
857 } 858 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698