Refactored VRService interaction and added VRServiceClient

Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG=389343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223
Cr-Commit-Position: refs/heads/master@{#408473}

[bajones, 2016-07-20 22:18:51]

bajones@chromium.org changed reviewers:
+ mkwst@chromium.org

[bajones, 2016-07-20 22:18:52]

mkwst@: Please take a look at modules/ and vr_service.mojom

[bajones, 2016-07-20 23:06:27]

Description was changed from

==========
Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG=389343
==========

to

==========
Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG=389343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Mike West, 2016-07-21 07:36:38]

The code looks pretty reasonable. How do you plan to test the new service
implementation?

https://codereview.chromium.org/2167643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2167643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:71: }
Nit: No {} around single-line clauses.

https://codereview.chromium.org/2167643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/VRController.cpp (right):

https://codereview.chromium.org/2167643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/VRController.cpp:13: 
Nit: Drop the blank line.

[bajones, 2016-07-21 17:41:03]

OOO till Monday at this point (looks like you are too!) but I wanted to ask
before I forget: By "new service" you mean the VRServiceClient, correct? If so
the answer is I hadn't considered it yet. (So thanks for bringing it up.) I'll
have to dig into what similar service/client pairs are doing for their testing.

[bajones, 2016-07-26 23:16:41]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 23:17:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2016-07-26 23:19:23]

Okay, got some simple tests in place for the Mojo service/client. There's really
not much functionality that needs testing at this point, but I'm glad the
framework is in place now so that adding new tests in the future as
functionality increases will be simpler. PTAL!

[commit-bot: I haz the power, 2016-07-26 23:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:33:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2016-07-27 00:01:46]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:02:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 02:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 02:54:22]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-07-27 08:39:23]

modules/ and mojom LGTM, thanks!

[bajones, 2016-07-27 15:46:25]

bajones@chromium.org changed reviewers:
+ sievers@chromium.org

[bajones, 2016-07-27 15:46:26]

Thanks Mike!

sievers@: Could you give a thumbs up to the minor render_frame_host_impl change?
Just changed which class is being registered as a Mojo service.

[no sievers, 2016-07-28 18:52:39]

On 2016/07/27 15:46:26, bajones wrote:
> Thanks Mike!
> 
> sievers@: Could you give a thumbs up to the minor render_frame_host_impl
change?
> Just changed which class is being registered as a Mojo service.

lgtm

[bajones, 2016-07-28 18:57:32]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-07-28 18:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 21:20:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-28 21:21:50]

Description was changed from

==========
Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG=389343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Refactored VRService interaction and added VRServiceClient

Lots of cleanup and architectural improvements. Allows bi-directional
communication, which will be needed when we start adding VR events. Also
refactors the relationship between the VRService and VRDeviceManager
(splits them apart) for cleaner connection handling and removed
WebLocalFrameImpl dependency on VRController.

BUG=389343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223
Cr-Commit-Position: refs/heads/master@{#408473}
==========

[commit-bot: I haz the power, 2016-07-28 21:21:52]

Patchset 4 (id:??) landed as
https://crrev.com/99e3d9baf2f84b162048a59487360e057cce3223
Cr-Commit-Position: refs/heads/master@{#408473}