Refactored VRService interaction and added VRServiceClient

device/vr/vr_device_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_VR_VR_DEVICE_MANAGER_H
 #define DEVICE_VR_VR_DEVICE_MANAGER_H
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
 #include "base/threading/thread_checker.h"
+#include "device/vr/vr_client_dispatcher.h"
 #include "device/vr/vr_device.h"
 #include "device/vr/vr_device_provider.h"
 #include "device/vr/vr_export.h"
 #include "device/vr/vr_service.mojom.h"
+#include "device/vr/vr_service_impl.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 
 namespace device {
 
-class VRDeviceManager : public VRService {
+class VRDeviceManager : public VRClientDispatcher {
  public:
-  DEVICE_VR_EXPORT ~VRDeviceManager() override;
-
-  DEVICE_VR_EXPORT static void BindRequest(
-      mojo::InterfaceRequest<VRService> request);
+  DEVICE_VR_EXPORT virtual ~VRDeviceManager();
 
   // Returns the VRDeviceManager singleton.
   static VRDeviceManager* GetInstance();
 
+  // Adds a listener for device manager events. VRDeviceManager does not own
+  // this object.
+  void AddService(VRServiceImpl* service);
+  void RemoveService(VRServiceImpl* service);
+
   DEVICE_VR_EXPORT mojo::Array<VRDisplayPtr> GetVRDevices();
   DEVICE_VR_EXPORT VRDevice* GetDevice(unsigned int index);
 
+  void OnDeviceChanged(VRDisplayPtr device) override;
+
  private:
   friend class VRDeviceManagerTest;
+  friend class VRServiceImplTest;
 
   VRDeviceManager();
   // Constructor for testing.
   DEVICE_VR_EXPORT explicit VRDeviceManager(
       std::unique_ptr<VRDeviceProvider> provider);
 
   static void SetInstance(VRDeviceManager* service);
   static bool HasInstance();
 
   void InitializeProviders();
   void RegisterProvider(std::unique_ptr<VRDeviceProvider> provider);
 
-  // mojom::VRService implementation
-  void GetDisplays(const GetDisplaysCallback& callback) override;
-  void GetPose(uint32_t index, const GetPoseCallback& callback) override;
-  void ResetPose(uint32_t index) override;
-
-  // Mojo connection error handler.
-  void OnConnectionError();
-
   using ProviderList = std::vector<linked_ptr<VRDeviceProvider>>;
   ProviderList providers_;
 
   // Devices are owned by their providers.
   using DeviceMap = std::map<unsigned int, VRDevice*>;
   DeviceMap devices_;
 
   bool vr_initialized_;
 
-  mojo::BindingSet<VRService> bindings_;
+  using ServiceList = std::vector<VRServiceImpl*>;
+  ServiceList services_;
 
   // For testing. If true will not delete self when consumer count reaches 0.
   bool keep_alive_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(VRDeviceManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_VR_VR_DEVICE_MANAGER_H