s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
Committed: https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9
Cr-Commit-Position: refs/heads/master@{#407465}

[Bence, 2016-07-21 17:30:20]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 17:30:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 18:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:33:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bence, 2016-07-21 19:16:04]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:40:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Bence, 2016-07-21 23:13:50]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-07-21 23:13:51]

Ryan: PTAL.  Thank you.

[Bence, 2016-07-21 23:15:38]

Description was changed from

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused EVENT_TYPE(HTTP2_SESSION_SYN_STREAM).
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

to

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

[Bence, 2016-07-21 23:15:39]

Description was changed from

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused EVENT_TYPE(HTTP2_SESSION_SYN_STREAM).
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

to

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

[Ryan Hamilton, 2016-07-22 23:32:34]

lgtm

[Bence, 2016-07-23 00:16:25]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-07-23 00:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 00:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 00:19:11]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Bence, 2016-07-25 12:12:40]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-07-25 12:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2167253002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-25 12:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 13:36:31]

Description was changed from

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

to

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

[commit-bot: I haz the power, 2016-07-25 13:36:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 13:38:00]

Description was changed from

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095
==========

to

==========
s/SYN_STREAM/HEADERS/ in frame types, method names, comments.

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095

Committed: https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9
Cr-Commit-Position: refs/heads/master@{#407465}
==========

[commit-bot: I haz the power, 2016-07-25 13:38:01]

Patchset 3 (id:??) landed as
https://crrev.com/4233140d9fb980c68a14bb014128a6df5c02e2d9
Cr-Commit-Position: refs/heads/master@{#407465}