Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 2167253002: s/SYN_STREAM/HEADERS/ in frame types, method names, comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_test_util_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index 6257f2c0753fc73d9c99421fd287d606454e70e9..0776b62ab1c6f57b07d5da0bba7e5a30c9e1321f 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -138,7 +138,7 @@ TEST_F(SpdyStreamTest, SendDataAfterOpen) {
kStreamUrl, 1, kPostBodyLength, LOWEST, NULL, 0));
AddWrite(req);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostSynReply(NULL, 0));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(NULL, 0));
AddRead(resp);
SpdySerializedFrame msg(
@@ -216,7 +216,7 @@ TEST_F(SpdyStreamTest, Trailers) {
spdy_util_.ConstructSpdyDataFrame(1, kPostBody, kPostBodyLength, true));
AddWrite(msg);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostSynReply(NULL, 0));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(NULL, 0));
AddRead(resp);
SpdySerializedFrame echo(
@@ -339,7 +339,7 @@ TEST_F(SpdyStreamTest, StreamError) {
kStreamUrl, 1, kPostBodyLength, LOWEST, NULL, 0));
AddWrite(req);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(resp);
SpdySerializedFrame msg(
@@ -423,7 +423,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenRequestResponse) {
1, chunk_data.data(), chunk_data.length(), true));
AddWrite(last_chunk);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostSynReply(NULL, 0));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(NULL, 0));
AddRead(resp);
AddReadEOF();
@@ -472,7 +472,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenBidirectional) {
kStreamUrl, 1, kPostBodyLength, LOWEST, NULL, 0));
AddWrite(req);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostSynReply(NULL, 0));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(NULL, 0));
AddRead(resp);
std::string chunk_data(kMaxSpdyFrameChunkSize, 'x');
@@ -529,7 +529,7 @@ TEST_F(SpdyStreamTest, UpperCaseHeaders) {
const char* const kExtraHeaders[] = {"X-UpperCase", "yes"};
SpdySerializedFrame reply(
- spdy_util_.ConstructSpdyGetSynReply(kExtraHeaders, 1, 1));
+ spdy_util_.ConstructSpdyGetReply(kExtraHeaders, 1, 1));
AddRead(reply);
SpdySerializedFrame rst(
@@ -574,7 +574,7 @@ TEST_F(SpdyStreamTest, UpperCaseHeadersOnPush) {
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
AddWrite(syn);
- SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(reply);
const char* const extra_headers[] = {"X-UpperCase", "yes"};
@@ -634,7 +634,7 @@ TEST_F(SpdyStreamTest, UpperCaseHeadersInHeadersFrame) {
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
AddWrite(syn);
- SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(reply);
SpdySerializedFrame push(
@@ -707,7 +707,7 @@ TEST_F(SpdyStreamTest, DuplicateHeaders) {
spdy_util_.ConstructSpdyGet(nullptr, 0, 1, LOWEST, true));
AddWrite(syn);
- SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(reply);
SpdySerializedFrame push(
@@ -874,7 +874,7 @@ void SpdyStreamTest::RunResumeAfterUnstallRequestResponseTest(
spdy_util_.ConstructSpdyDataFrame(1, kPostBody, kPostBodyLength, true));
AddWrite(body);
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(resp);
AddReadEOF();
@@ -946,7 +946,7 @@ void SpdyStreamTest::RunResumeAfterUnstallBidirectionalTest(
AddReadPause();
- SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame resp(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(resp);
SpdySerializedFrame msg(
@@ -1028,7 +1028,7 @@ TEST_F(SpdyStreamTest, ReceivedBytes) {
AddReadPause();
- SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetSynReply(NULL, 0, 1));
+ SpdySerializedFrame reply(spdy_util_.ConstructSpdyGetReply(NULL, 0, 1));
AddRead(reply);
AddReadPause();
« no previous file with comments | « net/spdy/spdy_stream.cc ('k') | net/spdy/spdy_test_util_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698