Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: net/spdy/spdy_write_queue_unittest.cc

Issue 2167253002: s/SYN_STREAM/HEADERS/ in frame types, method names, comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_write_queue_unittest.cc
diff --git a/net/spdy/spdy_write_queue_unittest.cc b/net/spdy/spdy_write_queue_unittest.cc
index 9ffacc840a93eb4b7f06c4a0e9760ea6392b3081..bcf4078ee9ca4893a3fc06ad22310bea7a3a7cf6 100644
--- a/net/spdy/spdy_write_queue_unittest.cc
+++ b/net/spdy/spdy_write_queue_unittest.cc
@@ -115,9 +115,9 @@ TEST_F(SpdyWriteQueueTest, DequeuesByPriority) {
std::unique_ptr<SpdyStream> stream_highest(MakeTestStream(HIGHEST));
// A NULL stream should still work.
- write_queue.Enqueue(LOW, SYN_STREAM, std::move(producer_low),
+ write_queue.Enqueue(LOW, HEADERS, std::move(producer_low),
base::WeakPtr<SpdyStream>());
- write_queue.Enqueue(MEDIUM, SYN_REPLY, std::move(producer_medium),
+ write_queue.Enqueue(MEDIUM, HEADERS, std::move(producer_medium),
stream_medium->GetWeakPtr());
write_queue.Enqueue(HIGHEST, RST_STREAM, std::move(producer_highest),
stream_highest->GetWeakPtr());
@@ -131,12 +131,12 @@ TEST_F(SpdyWriteQueueTest, DequeuesByPriority) {
EXPECT_EQ(stream_highest.get(), stream.get());
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
- EXPECT_EQ(SYN_REPLY, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ("MEDIUM", ProducerToString(std::move(frame_producer)));
EXPECT_EQ(stream_medium.get(), stream.get());
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
- EXPECT_EQ(SYN_STREAM, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ("LOW", ProducerToString(std::move(frame_producer)));
EXPECT_EQ(nullptr, stream.get());
@@ -156,9 +156,9 @@ TEST_F(SpdyWriteQueueTest, DequeuesFIFO) {
std::unique_ptr<SpdyStream> stream2(MakeTestStream(DEFAULT_PRIORITY));
std::unique_ptr<SpdyStream> stream3(MakeTestStream(DEFAULT_PRIORITY));
- write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, std::move(producer1),
+ write_queue.Enqueue(DEFAULT_PRIORITY, HEADERS, std::move(producer1),
stream1->GetWeakPtr());
- write_queue.Enqueue(DEFAULT_PRIORITY, SYN_REPLY, std::move(producer2),
+ write_queue.Enqueue(DEFAULT_PRIORITY, HEADERS, std::move(producer2),
stream2->GetWeakPtr());
write_queue.Enqueue(DEFAULT_PRIORITY, RST_STREAM, std::move(producer3),
stream3->GetWeakPtr());
@@ -167,12 +167,12 @@ TEST_F(SpdyWriteQueueTest, DequeuesFIFO) {
std::unique_ptr<SpdyBufferProducer> frame_producer;
base::WeakPtr<SpdyStream> stream;
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
- EXPECT_EQ(SYN_STREAM, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ(1, ProducerToInt(std::move(frame_producer)));
EXPECT_EQ(stream1.get(), stream.get());
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
- EXPECT_EQ(SYN_REPLY, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ(2, ProducerToInt(std::move(frame_producer)));
EXPECT_EQ(stream2.get(), stream.get());
@@ -196,7 +196,7 @@ TEST_F(SpdyWriteQueueTest, RemovePendingWritesForStream) {
for (int i = 0; i < 100; ++i) {
base::WeakPtr<SpdyStream> stream =
(((i % 3) == 0) ? stream1 : stream2)->GetWeakPtr();
- write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, IntToProducer(i), stream);
+ write_queue.Enqueue(DEFAULT_PRIORITY, HEADERS, IntToProducer(i), stream);
}
write_queue.RemovePendingWritesForStream(stream2->GetWeakPtr());
@@ -206,7 +206,7 @@ TEST_F(SpdyWriteQueueTest, RemovePendingWritesForStream) {
std::unique_ptr<SpdyBufferProducer> frame_producer;
base::WeakPtr<SpdyStream> stream;
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
- EXPECT_EQ(SYN_STREAM, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ(i, ProducerToInt(std::move(frame_producer)));
EXPECT_EQ(stream1.get(), stream.get());
}
@@ -238,7 +238,7 @@ TEST_F(SpdyWriteQueueTest, RemovePendingWritesForStreamsAfter) {
};
for (int i = 0; i < 100; ++i) {
- write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, IntToProducer(i),
+ write_queue.Enqueue(DEFAULT_PRIORITY, HEADERS, IntToProducer(i),
streams[i % arraysize(streams)]);
}
@@ -250,7 +250,7 @@ TEST_F(SpdyWriteQueueTest, RemovePendingWritesForStreamsAfter) {
base::WeakPtr<SpdyStream> stream;
ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream))
<< "Unable to Dequeue i: " << i;
- EXPECT_EQ(SYN_STREAM, frame_type);
+ EXPECT_EQ(HEADERS, frame_type);
EXPECT_EQ(i, ProducerToInt(std::move(frame_producer)));
EXPECT_EQ(stream1.get(), stream.get());
}
@@ -268,7 +268,7 @@ TEST_F(SpdyWriteQueueTest, Clear) {
SpdyWriteQueue write_queue;
for (int i = 0; i < 100; ++i) {
- write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, IntToProducer(i),
+ write_queue.Enqueue(DEFAULT_PRIORITY, HEADERS, IntToProducer(i),
base::WeakPtr<SpdyStream>());
}
@@ -283,7 +283,7 @@ TEST_F(SpdyWriteQueueTest, Clear) {
TEST_F(SpdyWriteQueueTest, RequeingProducerWithoutReentrance) {
SpdyWriteQueue queue;
queue.Enqueue(
- DEFAULT_PRIORITY, SYN_STREAM,
+ DEFAULT_PRIORITY, HEADERS,
std::unique_ptr<SpdyBufferProducer>(new RequeingBufferProducer(&queue)),
base::WeakPtr<SpdyStream>());
{
@@ -309,7 +309,7 @@ TEST_F(SpdyWriteQueueTest, RequeingProducerWithoutReentrance) {
TEST_F(SpdyWriteQueueTest, ReentranceOnClear) {
SpdyWriteQueue queue;
queue.Enqueue(
- DEFAULT_PRIORITY, SYN_STREAM,
+ DEFAULT_PRIORITY, HEADERS,
std::unique_ptr<SpdyBufferProducer>(new RequeingBufferProducer(&queue)),
base::WeakPtr<SpdyStream>());
@@ -330,7 +330,7 @@ TEST_F(SpdyWriteQueueTest, ReentranceOnRemovePendingWritesAfter) {
SpdyWriteQueue queue;
queue.Enqueue(
- DEFAULT_PRIORITY, SYN_STREAM,
+ DEFAULT_PRIORITY, HEADERS,
std::unique_ptr<SpdyBufferProducer>(new RequeingBufferProducer(&queue)),
stream->GetWeakPtr());
@@ -351,7 +351,7 @@ TEST_F(SpdyWriteQueueTest, ReentranceOnRemovePendingWritesForStream) {
SpdyWriteQueue queue;
queue.Enqueue(
- DEFAULT_PRIORITY, SYN_STREAM,
+ DEFAULT_PRIORITY, HEADERS,
std::unique_ptr<SpdyBufferProducer>(new RequeingBufferProducer(&queue)),
stream->GetWeakPtr());
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698