Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1679)

Unified Diff: net/spdy/spdy_proxy_client_socket_unittest.cc

Issue 2167253002: s/SYN_STREAM/HEADERS/ in frame types, method names, comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_proxy_client_socket_unittest.cc
diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc
index b2cdcbd12d5f7caa4989991d410b3ae26fba52b1..0267264b5728e29d4b156f2d48f800cf7159a916 100644
--- a/net/spdy/spdy_proxy_client_socket_unittest.cc
+++ b/net/spdy/spdy_proxy_client_socket_unittest.cc
@@ -298,33 +298,33 @@ void SpdyProxyClientSocketTest::PopulateConnectReplyIR(SpdyHeaderBlock* block,
(*block)[spdy_util_.GetStatusKey()] = status;
}
-// Constructs a standard SPDY SYN_STREAM frame for a CONNECT request.
+// Constructs a standard SPDY HEADERS frame for a CONNECT request.
SpdySerializedFrame SpdyProxyClientSocketTest::ConstructConnectRequestFrame() {
SpdyHeaderBlock block;
PopulateConnectRequestIR(&block);
- return spdy_util_.ConstructSpdySyn(kStreamId, std::move(block), LOWEST,
- false);
+ return spdy_util_.ConstructSpdyHeaders(kStreamId, std::move(block), LOWEST,
+ false);
}
-// Constructs a SPDY SYN_STREAM frame for a CONNECT request which includes
+// Constructs a SPDY HEADERS frame for a CONNECT request which includes
// Proxy-Authorization headers.
SpdySerializedFrame
SpdyProxyClientSocketTest::ConstructConnectAuthRequestFrame() {
SpdyHeaderBlock block;
PopulateConnectRequestIR(&block);
block["proxy-authorization"] = "Basic Zm9vOmJhcg==";
- return spdy_util_.ConstructSpdySyn(kStreamId, std::move(block), LOWEST,
- false);
+ return spdy_util_.ConstructSpdyHeaders(kStreamId, std::move(block), LOWEST,
+ false);
}
-// Constructs a standard SPDY SYN_REPLY frame to match the SPDY CONNECT.
+// Constructs a standard SPDY HEADERS frame to match the SPDY CONNECT.
SpdySerializedFrame SpdyProxyClientSocketTest::ConstructConnectReplyFrame() {
SpdyHeaderBlock block;
PopulateConnectReplyIR(&block, "200");
return spdy_util_.ConstructSpdyReply(kStreamId, std::move(block));
}
-// Constructs a standard SPDY SYN_REPLY frame to match the SPDY CONNECT,
+// Constructs a standard SPDY HEADERS frame to match the SPDY CONNECT,
// including Proxy-Authenticate headers.
SpdySerializedFrame
SpdyProxyClientSocketTest::ConstructConnectAuthReplyFrame() {
@@ -334,7 +334,7 @@ SpdyProxyClientSocketTest::ConstructConnectAuthReplyFrame() {
return spdy_util_.ConstructSpdyReply(kStreamId, std::move(block));
}
-// Constructs a SPDY SYN_REPLY frame with an HTTP 302 redirect.
+// Constructs a SPDY HEADERS frame with an HTTP 302 redirect.
SpdySerializedFrame
SpdyProxyClientSocketTest::ConstructConnectRedirectReplyFrame() {
SpdyHeaderBlock block;
@@ -344,7 +344,7 @@ SpdyProxyClientSocketTest::ConstructConnectRedirectReplyFrame() {
return spdy_util_.ConstructSpdyReply(kStreamId, std::move(block));
}
-// Constructs a SPDY SYN_REPLY frame with an HTTP 500 error.
+// Constructs a SPDY HEADERS frame with an HTTP 500 error.
SpdySerializedFrame
SpdyProxyClientSocketTest::ConstructConnectErrorReplyFrame() {
SpdyHeaderBlock block;
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698