Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions (Closed)

Created:
4 years, 5 months ago by Philipp Keck
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
Marc Treib, chromium-reviews, arv+watch_chromium.org, ntp-dev+reviews_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename discard to dismiss for NTP snippets and content suggestions We agreed to use the term 'dismiss' instead of 'discard' for the action performed by the user to remove content suggestions from the NTP. These changes are only for the non-Android part. The renaming for the Android part will follow after or during the ongoing refactoring there. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2646c95b4156f62a44706d00795cac1033a79999 Cr-Commit-Position: refs/heads/master@{#407456}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -131 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/snippets_internals.html View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/snippets_internals.js View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M components/ntp_snippets/content_suggestions_provider.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/ntp_snippets/ntp_snippet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/ntp_snippet.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 5 chunks +10 lines, -10 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 9 chunks +24 lines, -24 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 2 5 chunks +21 lines, -21 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/ntp_snippets/proto/ntp_snippets.proto View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Philipp Keck
PTAL Does this need a bug?
4 years, 5 months ago (2016-07-21 12:50:32 UTC) #3
Bernhard Bauer
LGTM +Michael FYI
4 years, 5 months ago (2016-07-21 13:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167063003/40001
4 years, 5 months ago (2016-07-25 11:18:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 12:19:07 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 12:21:16 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2646c95b4156f62a44706d00795cac1033a79999
Cr-Commit-Position: refs/heads/master@{#407456}

Powered by Google App Engine
This is Rietveld 408576698