Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen
Patch Set: Fix unit test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_provider.h
diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h
index 43f211bd96a430c9a2517c35e597ee29697e385f..995db450679bf008f38f2340dadc230ac4887f4b 100644
--- a/components/ntp_snippets/content_suggestions_provider.h
+++ b/components/ntp_snippets/content_suggestions_provider.h
@@ -71,11 +71,11 @@ class ContentSuggestionsProvider {
virtual ContentSuggestionsCategoryStatus GetCategoryStatus(
ContentSuggestionsCategory category) = 0;
- // Discards the suggestion with the given ID. A provider needs to ensure that
- // a once-discarded suggestion is never delivered again (through the
+ // Dismisses the suggestion with the given ID. A provider needs to ensure that
+ // a once-dismissed suggestion is never delivered again (through the
// Observer). The provider must not call Observer::OnSuggestionsChanged if the
- // removal of the discarded suggestion is the only change.
- virtual void DiscardSuggestion(const std::string& suggestion_id) = 0;
+ // removal of the dismissed suggestion is the only change.
+ virtual void DismissSuggestion(const std::string& suggestion_id) = 0;
// Fetches the image for the suggestion with the given ID and returns it
// through the callback. This fetch may occur locally or from the internet.
@@ -88,11 +88,11 @@ class ContentSuggestionsProvider {
// fetch starts from scratch.
virtual void ClearCachedSuggestionsForDebugging() = 0;
- // Used only for debugging purposes. Clears the cache of discarded
+ // Used only for debugging purposes. Clears the cache of dismissed
// suggestions, if present, so that no suggestions are suppressed. This does
- // not necessarily make previously discarded suggestions reappear, as they may
+ // not necessarily make previously dismissed suggestions reappear, as they may
// have been permanently deleted, depending on the provider implementation.
- virtual void ClearDiscardedSuggestionsForDebugging() = 0;
+ virtual void ClearDismissedSuggestionsForDebugging() = 0;
const std::vector<ContentSuggestionsCategory>& provided_categories() const {
return provided_categories_;
« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698