Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen
Patch Set: Fix unit test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
index ebed24c0d5d84494e5cd4d9ac80896efd3edb28c..ed0dd39dc0c27838594b900d15788f72d3522f5d 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
@@ -46,10 +46,10 @@ OfflinePageSuggestionsProvider::GetCategoryStatus(
return category_status_;
}
-void OfflinePageSuggestionsProvider::DiscardSuggestion(
+void OfflinePageSuggestionsProvider::DismissSuggestion(
const std::string& suggestion_id) {
// TODO(pke): Implement some "dont show on NTP anymore" behaviour,
- // then also implement ClearDiscardedSuggestionsForDebugging.
+ // then also implement ClearDismissedSuggestionsForDebugging.
}
void OfflinePageSuggestionsProvider::FetchSuggestionImage(
@@ -62,8 +62,8 @@ void OfflinePageSuggestionsProvider::ClearCachedSuggestionsForDebugging() {
// Ignored.
}
-void OfflinePageSuggestionsProvider::ClearDiscardedSuggestionsForDebugging() {
- // TODO(pke): Implement when discarded suggestions are supported.
+void OfflinePageSuggestionsProvider::ClearDismissedSuggestionsForDebugging() {
+ // TODO(pke): Implement when dismissed suggestions are supported.
}
void OfflinePageSuggestionsProvider::OfflinePageModelLoaded(

Powered by Google App Engine
This is Rietveld 408576698