components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h - Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen

Patch Set: Fix unit test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service_unittest.cc ('k') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

index 2abc638a0a9fbdaa3b4115cfe431cdba6ea457bd..651342d74d466d188bc2810e07be00f892d4cd60 100644

--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

@@ -43,11 +43,11 @@ class OfflinePageSuggestionsProvider

void SetObserver(ContentSuggestionsProvider::Observer* observer) override;

ContentSuggestionsCategoryStatus GetCategoryStatus(

ContentSuggestionsCategory category) override;

- void DiscardSuggestion(const std::string& suggestion_id) override;

+ void DismissSuggestion(const std::string& suggestion_id) override;

void FetchSuggestionImage(const std::string& suggestion_id,

const ImageFetchedCallback& callback) override;

void ClearCachedSuggestionsForDebugging() override;

- void ClearDiscardedSuggestionsForDebugging() override;

+ void ClearDismissedSuggestionsForDebugging() override;

// OfflinePageModel::Observer implementation.

void OfflinePageModelLoaded(offline_pages::OfflinePageModel* model) override;