Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2165283002: Remove DrawFace enum from GrPipelineBuilder (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove DrawFace enum from GrPipelineBuilder This gets GrPipelineBuilder.h out of the headers GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002 Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34 Committed: https://skia.googlesource.com/skia/+/5fa7f30331585f78cf0f81ac185abbff1fee1152

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Add casts for Vulkan #

Patch Set 4 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -47 lines) Patch
M include/gpu/GrTypesPriv.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 4 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/instanced/InstancedRendering.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipeline.cpp View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
robertphillips
4 years, 5 months ago (2016-07-21 14:05:06 UTC) #4
bsalomon
4 years, 5 months ago (2016-07-21 14:16:10 UTC) #6
robertphillips
On 2016/07/21 14:16:10, bsalomon wrote: ??
4 years, 5 months ago (2016-07-21 14:17:19 UTC) #7
bsalomon
oooops, lgtm
4 years, 5 months ago (2016-07-21 14:17:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165283002/20001
4 years, 5 months ago (2016-07-21 14:57:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34
4 years, 5 months ago (2016-07-21 14:58:44 UTC) #16
robertphillips
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2167193002/ by robertphillips@google.com. ...
4 years, 5 months ago (2016-07-21 15:17:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165283002/60001
4 years, 5 months ago (2016-07-21 16:20:09 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:21:10 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5fa7f30331585f78cf0f81ac185abbff1fee1152

Powered by Google App Engine
This is Rietveld 408576698