src/gpu/vk/GrVkPipelineState.cpp - Issue 2165283002: Remove DrawFace enum from GrPipelineBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkPipelineState.cpp

Issue 2165283002: Remove DrawFace enum from GrPipelineBuilder (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: try again Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkPipelineState.cpp

diff --git a/src/gpu/vk/GrVkPipelineState.cpp b/src/gpu/vk/GrVkPipelineState.cpp

index 94d6305bc951a5eba89a6bc8839d94f7a6e15990..cb3751191cca84f07c4a1a531612e591723d1b44 100644

--- a/src/gpu/vk/GrVkPipelineState.cpp

+++ b/src/gpu/vk/GrVkPipelineState.cpp

@@ -487,8 +487,8 @@ void GrVkPipelineState::BuildStateKey(const GrPipeline& pipeline, GrPrimitiveTyp

pipeline.getStencil().genKey(&b);

- SkASSERT(sizeof(GrPipelineBuilder::DrawFace) <= sizeof(uint32_t));

- b.add32(pipeline.getDrawFace());

+ SkASSERT(sizeof(GrDrawFace) <= sizeof(uint32_t));

+ b.add32((int32_t)pipeline.getDrawFace());

b.add32(get_blend_info_key(pipeline));

« no previous file with comments | « src/gpu/vk/GrVkPipeline.cpp ('k') | tools/gpu/GrTest.cpp » ('j') | no next file with comments »