Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216503004: SK_SUPPORT_LEGACY_GRTYPES to hide duplicate types from SkTypes.h (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SK_SUPPORT_LEGACY_GRTYPES to hide duplicate types from SkTypes.h BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -272 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrGlyph.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/gpu/GrPoint.h View 1 chunk +4 lines, -2 lines 1 comment Download
M include/gpu/GrTexture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrTypes.h View 5 chunks +28 lines, -26 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 9 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 13 chunks +31 lines, -31 lines 0 comments Download
M src/gpu/GrAllocPool.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 12 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/GrMemoryPool.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 8 chunks +19 lines, -19 lines 0 comments Download
M src/gpu/GrPathUtils.h View 4 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 10 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
6 years, 9 months ago (2014-03-28 15:04:43 UTC) #1
reed1
I presume I'll need to define the guard for Chrome at first... but not sure
6 years, 9 months ago (2014-03-28 15:05:13 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/216503004/diff/1/include/gpu/GrPoint.h File include/gpu/GrPoint.h (right): https://codereview.chromium.org/216503004/diff/1/include/gpu/GrPoint.h#newcode18 include/gpu/GrPoint.h:18: #if 0 Can we just delete this?
6 years, 9 months ago (2014-03-28 15:13:38 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-28 16:16:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/216503004/1
6 years, 9 months ago (2014-03-28 16:16:40 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 17:59:09 UTC) #6
Message was sent while issue was closed. 
Change committed as 13982

Powered by Google App Engine
This is Rietveld 408576698