Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic… (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
dmazzoni, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, jam, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic and aria-live. BUG=590341 R=dmazzoni@chromium.org TESTED=Manually with Voiceover, browser tests Committed: https://crrev.com/04bbdb09093ed2a5b005abda85e10284a4dc7fc0 Cr-Commit-Position: refs/heads/master@{#406600}

Patch Set 1 #

Patch Set 2 : Fixed test expectations. #

Patch Set 3 : Fixed aria-atomic test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M content/test/data/accessibility/aria/aria-alert.html View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-alert-expected-mac.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-alert-expected-win.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-atomic.html View 1 chunk +5 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-atomic-expected-android.txt View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-atomic-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-atomic-expected-win.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-live.html View 2 chunks +4 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-live-expected-android.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-live-expected-mac.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-live-expected-win.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-status.html View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
nektarios
4 years, 5 months ago (2016-07-19 19:49:21 UTC) #1
dmazzoni
lgtm
4 years, 5 months ago (2016-07-19 20:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163673003/20001
4 years, 5 months ago (2016-07-19 23:12:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/106987)
4 years, 5 months ago (2016-07-20 03:22:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163673003/40001
4 years, 5 months ago (2016-07-20 16:04:44 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 17:30:54 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 17:30:59 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:32:41 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/04bbdb09093ed2a5b005abda85e10284a4dc7fc0
Cr-Commit-Position: refs/heads/master@{#406600}

Powered by Google App Engine
This is Rietveld 408576698