third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed aria-atomic test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/data/accessibility/aria/aria-status.html ('k') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index 3cf57b9846c1fbab4ead98a655ade10a90b46edd..638785de13357f3d8d77cf0412de464f78bdbbba 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -1403,9 +1403,11 @@ const AtomicString& AXLayoutObject::liveRegionRelevant() const

bool AXLayoutObject::liveRegionAtomic() const

{

- // ARIA role status should have implicit aria-atomic value of true.

- if (getAttribute(aria_atomicAttr).isEmpty() && roleValue() == StatusRole)

+ // ARIA roles "alert" and "status" should have an implicit aria-atomic value of true.

+ if (getAttribute(aria_atomicAttr).isEmpty()

+ && (roleValue() == AlertRole || roleValue() == StatusRole)) {

return true;

+ }

return elementAttributeValue(aria_atomicAttr);

}