Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed aria-atomic test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 1396
1397 // Default aria-relevant = "additions text". 1397 // Default aria-relevant = "additions text".
1398 if (relevant.isEmpty()) 1398 if (relevant.isEmpty())
1399 return defaultLiveRegionRelevant; 1399 return defaultLiveRegionRelevant;
1400 1400
1401 return relevant; 1401 return relevant;
1402 } 1402 }
1403 1403
1404 bool AXLayoutObject::liveRegionAtomic() const 1404 bool AXLayoutObject::liveRegionAtomic() const
1405 { 1405 {
1406 // ARIA role status should have implicit aria-atomic value of true. 1406 // ARIA roles "alert" and "status" should have an implicit aria-atomic value of true.
1407 if (getAttribute(aria_atomicAttr).isEmpty() && roleValue() == StatusRole) 1407 if (getAttribute(aria_atomicAttr).isEmpty()
1408 && (roleValue() == AlertRole || roleValue() == StatusRole)) {
1408 return true; 1409 return true;
1410 }
1409 return elementAttributeValue(aria_atomicAttr); 1411 return elementAttributeValue(aria_atomicAttr);
1410 } 1412 }
1411 1413
1412 bool AXLayoutObject::liveRegionBusy() const 1414 bool AXLayoutObject::liveRegionBusy() const
1413 { 1415 {
1414 return elementAttributeValue(aria_busyAttr); 1416 return elementAttributeValue(aria_busyAttr);
1415 } 1417 }
1416 1418
1417 // 1419 //
1418 // Position and size. 1420 // Position and size.
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
2579 result.unite(labelRect); 2581 result.unite(labelRect);
2580 } 2582 }
2581 } 2583 }
2582 } 2584 }
2583 } 2585 }
2584 2586
2585 return result; 2587 return result;
2586 } 2588 }
2587 2589
2588 } // namespace blink 2590 } // namespace blink
OLDNEW
« no previous file with comments | « content/test/data/accessibility/aria/aria-status.html ('k') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698