third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2163673003: Made ARIA alerts have an implicit aria-atomic of true and strengthened tests concerning aria-atomic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed aria-atomic test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index cbb0e6d877bfc788cab93a2113662ca1c6c1c971..75ba25eb19616bf1d5d9a04a12fbe68f35360b59 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -1118,13 +1118,13 @@ const AtomicString& AXObject::containerLiveRegionRelevant() const

bool AXObject::containerLiveRegionAtomic() const

{

updateCachedAttributeValuesIfNeeded();

- return m_cachedLiveRegionRoot ? m_cachedLiveRegionRoot->liveRegionAtomic() : false;

+ return m_cachedLiveRegionRoot && m_cachedLiveRegionRoot->liveRegionAtomic();

}

bool AXObject::containerLiveRegionBusy() const

{

updateCachedAttributeValuesIfNeeded();

- return m_cachedLiveRegionRoot ? m_cachedLiveRegionRoot->liveRegionBusy() : false;

+ return m_cachedLiveRegionRoot && m_cachedLiveRegionRoot->liveRegionBusy();

}

void AXObject::markCachedElementRectDirty() const

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »