base/task/cancelable_task_tracker_unittest.cc - Issue 2163023002: Unify usage of logging/assert macros in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task/cancelable_task_tracker_unittest.cc

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task/cancelable_task_tracker_unittest.cc

diff --git a/base/task/cancelable_task_tracker_unittest.cc b/base/task/cancelable_task_tracker_unittest.cc

index ff9e40b855eaebce8d77f362ed827757f151cb5f..78f9854708856efdde262871ce688ddb7344a22e 100644

--- a/base/task/cancelable_task_tracker_unittest.cc

+++ b/base/task/cancelable_task_tracker_unittest.cc

@@ -346,7 +346,7 @@ class CancelableTaskTrackerDeathTest : public CancelableTaskTrackerTest {

// Duplicated from base/threading/thread_checker.h so that we can be

// good citizens there and undef the macro.

-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

+#if DCHECK_IS_ON()

#define ENABLE_THREAD_CHECKER 1

danakj 2016/07/19 20:17:01 Do we need this separate #define, or just use DCHE

gab 2016/07/20 02:43:58 Done.

#else

#define ENABLE_THREAD_CHECKER 0