Unify usage of logging/assert macros in base/

Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing
https://codereview.chromium.org/2135413003/ for https://codereview.chromium.org/2103883004/#msg14)

Committed: https://crrev.com/190f7546ebe213c61874ec8885be95c0f98a84d1
Cr-Commit-Position: refs/heads/master@{#409036}

[gab, 2016-07-19 19:38:44]

Description was changed from

==========
Unify usage of logging/assert macros in base/

BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Leaks ENABLE_DLOG macro from logging.h so that code ifdef'ing variables for
DLOGs has
  a compile-time thing to base itself on (instead of duplicating the definition
or incorrectly
  basing itself on NDEBUG only).

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()


BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

[gab, 2016-07-19 19:41:36]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-07-19 19:41:37]

Dana, PTAL. Grew tired of this pattern all over Chrome (especially DCHECKs
hidden behind NDEBUG and not honoring DCHECK_ALWAYS_ON). Hoping that changing it
in base/ will leak the new paradigm over rest of codebase.

WDYT of leaking ENABLE_DLOG macro? Was going to make a #if DLOG_IS_ON() but it's
already defined (and can't be resolved at compile-time).

[danakj, 2016-07-19 20:17:02]

The fact that DLOG doesn't use variables when !DCHECK_IS_ON() but DCHECK does...
:|

https://codereview.chromium.org/2163023002/diff/1/base/i18n/icu_util.cc
File base/i18n/icu_util.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/i18n/icu_util.cc#newco...
base/i18n/icu_util.cc:57: #endif  // !defined(NDEBUG)
fix this

https://codereview.chromium.org/2163023002/diff/1/base/logging.h
File base/logging.h (left):

https://codereview.chromium.org/2163023002/diff/1/base/logging.h#oldcode655
base/logging.h:655: #undef ENABLE_DLOG
Hm.. idk why we need both here. Can we just delete ENABLE_DLOG and use
DCHECK_IS_ON()?

https://codereview.chromium.org/2163023002/diff/1/base/task/cancelable_task_t...
File base/task/cancelable_task_tracker_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/task/cancelable_task_t...
base/task/cancelable_task_tracker_unittest.cc:350: #define ENABLE_THREAD_CHECKER
1
Do we need this separate #define, or just use DCHECK_IS_ON?

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
File base/threading/non_thread_safe.h (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
base/threading/non_thread_safe.h:17: #define ENABLE_NON_THREAD_SAFE 1
Same question, why not just DCHECK_IS_ON() instead?

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
File base/threading/non_thread_safe_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
base/threading/non_thread_safe_unittest.cc:17: #define ENABLE_NON_THREAD_SAFE 1
and here..

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_check...
File base/threading/thread_checker_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_check...
base/threading/thread_checker_unittest.cc:17: #define ENABLE_THREAD_CHECKER 1
and here.. and in the thread_checker.h?
https://cs.chromium.org/chromium/src/base/threading/thread_checker.h?rcl=0&l=16

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_restr...
File base/threading/thread_restrictions.h (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_restr...
base/threading/thread_restrictions.h:14: #define ENABLE_THREAD_RESTRICTIONS 1
dittos?

[gab, 2016-07-20 02:43:58]

Thanks, done, PTAL

https://codereview.chromium.org/2163023002/diff/1/base/i18n/icu_util.cc
File base/i18n/icu_util.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/i18n/icu_util.cc#newco...
base/i18n/icu_util.cc:57: #endif  // !defined(NDEBUG)
On 2016/07/19 20:17:01, danakj wrote:
> fix this

Done.

https://codereview.chromium.org/2163023002/diff/1/base/logging.h
File base/logging.h (left):

https://codereview.chromium.org/2163023002/diff/1/base/logging.h#oldcode655
base/logging.h:655: #undef ENABLE_DLOG
On 2016/07/19 20:17:01, danakj wrote:
> Hm.. idk why we need both here. Can we just delete ENABLE_DLOG and use
> DCHECK_IS_ON()?

Sure, though it's a bit weird to have

#if DCHECK_IS_ON()
  bool result =
#endif
     MyCallWithResult();
  DLOG_IF(!result, "blah");

because DLOG and DCHECK are two different things. So I understand wanting two
macros even if they have the same definition... That's why I wanted to add
DLOG_IS_ON() but it already exists and means something else... Maybe we could
add DLOG_IS_ENABLED()?

Anyways, replaced ENABLE_DLOG with DCHECK_IS_ON() directly for now, let me know
what you think.

https://codereview.chromium.org/2163023002/diff/1/base/task/cancelable_task_t...
File base/task/cancelable_task_tracker_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/task/cancelable_task_t...
base/task/cancelable_task_tracker_unittest.cc:350: #define ENABLE_THREAD_CHECKER
1
On 2016/07/19 20:17:01, danakj wrote:
> Do we need this separate #define, or just use DCHECK_IS_ON?

Done.

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
File base/threading/non_thread_safe.h (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
base/threading/non_thread_safe.h:17: #define ENABLE_NON_THREAD_SAFE 1
On 2016/07/19 20:17:01, danakj wrote:
> Same question, why not just DCHECK_IS_ON() instead?

Done.

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
File base/threading/non_thread_safe_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/non_thread_s...
base/threading/non_thread_safe_unittest.cc:17: #define ENABLE_NON_THREAD_SAFE 1
On 2016/07/19 20:17:01, danakj wrote:
> and here..

Done.

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_check...
File base/threading/thread_checker_unittest.cc (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_check...
base/threading/thread_checker_unittest.cc:17: #define ENABLE_THREAD_CHECKER 1
On 2016/07/19 20:17:01, danakj wrote:
> and here.. and in the thread_checker.h?
>
https://cs.chromium.org/chromium/src/base/threading/thread_checker.h?rcl=0&l=16

Done.

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_restr...
File base/threading/thread_restrictions.h (right):

https://codereview.chromium.org/2163023002/diff/1/base/threading/thread_restr...
base/threading/thread_restrictions.h:14: #define ENABLE_THREAD_RESTRICTIONS 1
On 2016/07/19 20:17:02, danakj wrote:
> dittos?

This one was used across the codebase, switched to DCHECK_IS_ON() for now but
perhaps it was more explicit with ENABLE_THREAD_RESTRICTIONS?

[gab, 2016-07-20 02:44:17]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 02:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-07-20 02:44:56]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Leaks ENABLE_DLOG macro from logging.h so that code ifdef'ing variables for
DLOGs has
  a compile-time thing to base itself on (instead of duplicating the definition
or incorrectly
  basing itself on NDEBUG only).

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()


BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

[commit-bot: I haz the power, 2016-07-20 02:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:59:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-07-20 03:15:06]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 03:15:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-07-20 03:17:53]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-07-20 03:18:01]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-07-20 03:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 03:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 03:39:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2016-07-20 16:14:41]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 16:15:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-07-20 16:15:54]

Decided to go a notch further cleaning up death tests, extracted to a precursor
CL @ https://codereview.chromium.org/2162053006/

[commit-bot: I haz the power, 2016-07-20 16:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:26:06]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[gab, 2016-07-20 17:06:22]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 17:17:51]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-07-20 20:03:03]

I think it'd be nicer if DLOG_IF worked like DCHECK and always referenced the
condition even if not used. But this is def better than before, I like it. LGTM

https://codereview.chromium.org/2163023002/diff/120001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2163023002/diff/120001/base/logging.h#newcode632
base/logging.h:632: // (which may reference a variable defined only if NDEBUG is
not defined).
This comment looks a bit wrong wtf NDBUG right? Should it say a variable defined
only if DCHECK_IS_ON()?

[danakj, 2016-07-20 20:03:30]

We should note that this will enable some dchecks on the waterfall that didn't
run before, which might turn up some things.

[gab, 2016-07-20 21:01:29]

On 2016/07/20 20:03:03, danakj wrote:
> I think it'd be nicer if DLOG_IF worked like DCHECK and always referenced the
> condition even if not used. But this is def better than before, I like it.
LGTM

Yea, maybe, definitely not in the scope of this cleanup which is already a
derail from what I'm intending to do :-).

> We should note that this will enable some dchecks on the waterfall that didn't
> run before, which might turn up some things.

Yes, noted in CL description already (or did you want me to mention "waterfall"
explicitly?)

https://codereview.chromium.org/2163023002/diff/120001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2163023002/diff/120001/base/logging.h#newcode632
base/logging.h:632: // (which may reference a variable defined only if NDEBUG is
not defined).
On 2016/07/20 20:03:03, danakj wrote:
> This comment looks a bit wrong wtf NDBUG right? Should it say a variable
defined
> only if DCHECK_IS_ON()?

Done.

[gab, 2016-07-20 21:02:26]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)

NO_DEPENDENCY_CHECKS=true
==========

[danakj, 2016-07-20 21:38:17]

On Wed, Jul 20, 2016 at 2:01 PM, <gab@chromium.org> wrote:

> On 2016/07/20 20:03:03, danakj wrote:
> > I think it'd be nicer if DLOG_IF worked like DCHECK and always
> referenced the
> > condition even if not used. But this is def better than before, I like
> it.
> LGTM
>
> Yea, maybe, definitely not in the scope of this cleanup which is already a
> derail from what I'm intending to do :-).
>
> > We should note that this will enable some dchecks on the waterfall that
> didn't
> > run before, which might turn up some things.
>
> Yes, noted in CL description already (or did you want me to mention
> "waterfall"
> explicitly?)
>

Oh, no just suggesting you prepare yourself emotionally :)

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gab, 2016-07-25 15:07:47]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)

NO_DEPENDENCY_CHECKS=true
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)

NO_DEPENDENCY_CHECKS=true
==========

[gab, 2016-07-25 15:07:52]

gab@chromium.org changed reviewers:
+ alokp@chromium.org, boliu@chromium.org, rkaplow@chromium.org

[gab, 2016-07-25 15:07:53]

TBRs for side-effects (though this CL is still blocked on pending precursor CL
so you may get to review before this lands :-)):

 - rkaplow for chrome/browser/metrics/
 - alokp for chromecast/
 - boliu for device/power_save_blocker/

Thanks!

[boliu, 2016-07-25 15:35:11]

lgtm

[gab, 2016-07-25 15:57:00]

Patchset #9 (id:180001) has been deleted

[rkaplow, 2016-07-25 18:38:29]

lgtm

[alokp, 2016-07-28 17:30:28]

chromecast/ lgtm

[gab, 2016-08-01 15:47:08]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)

NO_DEPENDENCY_CHECKS=true
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

[gab, 2016-08-01 16:41:19]

The CQ bit was checked by gab@chromium.org

[gab, 2016-08-01 16:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
boliu@chromium.org, rkaplow@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2163023002/#ps210001
(title: "merge up to r408965")

[commit-bot: I haz the power, 2016-08-01 16:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 17:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:19:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gab, 2016-08-01 17:52:13]

The CQ bit was checked by gab@chromium.org

[gab, 2016-08-01 17:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
rkaplow@chromium.org, boliu@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2163023002/#ps230001
(title: "fix base/android/build_info.cc compile")

[commit-bot: I haz the power, 2016-08-01 17:52:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:04:24]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

[commit-bot: I haz the power, 2016-08-01 20:04:26]

Committed patchset #11 (id:230001)

[commit-bot: I haz the power, 2016-08-01 20:06:56]

Description was changed from

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing 
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)
==========

to

==========
Unify usage of logging/assert macros in base/

* Enables following checks in Release+DCHECK_ALWAYS_ON build (previous DCHECKs
behind !NDEBUG):
 - icu_util
 - LazyInstance
 - CancellationFlag

* Unifies ENABLE_DLOG into DCHECK_IS_ON()

* Mass replaces (!NDEBUG || DCHECK_ALWAYS_ON) with DCHECK_IS_ON()

TBR=rkaplow, alokp, boliu
 - rkaplow for chrome/browser/metrics/ side-effects
 - alokp for chromecast/ side-effects
 - boliu for device/power_save_blocker/ side-effects
BUG=622400
(grew tired of DCHECKs behind NDEBUG when writing
https://codereview.chromium.org/2135413003/ for
https://codereview.chromium.org/2103883004/#msg14)

Committed: https://crrev.com/190f7546ebe213c61874ec8885be95c0f98a84d1
Cr-Commit-Position: refs/heads/master@{#409036}
==========

[commit-bot: I haz the power, 2016-08-01 20:06:58]

Patchset 11 (id:??) landed as
https://crrev.com/190f7546ebe213c61874ec8885be95c0f98a84d1
Cr-Commit-Position: refs/heads/master@{#409036}